Skip to content

Autocomplete race condition #1446

@gwillen

Description

@gwillen

I think there's a race condition in autocomplete on Rocket. It doesn't always use the most-current version of the autocomplete list when you press TAB; instead it uses what it's loaded so far.

For example, if I press ":-)", then wait awhile, then press TAB, I get the :-) emoji; but if I press ":-)TAB", with the TAB happening as fast as possible, I get some other emoji (which one depends on which one I've most commonly/recently used.)

For emoji, this wouldn't be a big problem, since I would never autocomplete an emoji on purpose, except for #1318 which means the list pops up unwanted, and the fact that, if I type an emoji at the end of a line, my ENTER gets interpreted as tab completion instead of message sending. (The latter is pretty annoying, and I wish ENTER were never autocomplete, or I could disable it.)

I can get it to do this for usernames too, but emoji are easier to reproduce it with because everyone has the same set, and lots of them have the same prefixes.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Metadata

Metadata

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions