Skip to content

CROWD sync should not be interrupted when user not found #12929

@piotrkochan

Description

@piotrkochan

Description:

Users in CROWD sometimes changes. That's being said, if for example user get new E-Mail address then CROWD Sync fails and next accounts are not synced.

Steps to reproduce:

  1. Hard because you need to have Crowd server
  2. You may temporary throw exception as in https://github.com/RocketChat/Rocket.Chat/blob/develop/packages/rocketchat-crowd/server/crowd.js#L159 for example in 3rd iteration of users.forEach for debugging

Expected behavior:

  1. Warning about user reported,
  2. But loop must not be interrupted.

Actual behavior:

  1. An error is reported
  2. Loop interrupted, no more users synced.

Server Setup Information:

  • Version of Rocket.Chat Server: 0.72
  • Operating System: not relevant
  • Deployment Method: not relevant
  • Number of Running Instances: not relevant
  • DB Replicaset Oplog: not relevant
  • NodeJS Version: 8.11
  • MongoDB Version: not relevant

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions