Skip to content

Room meta no longer in message stream #12574

@timkinnane

Description

@timkinnane

Working on current #develop branch (because I need other fixes included there), the __my_messages__ stream no longer includes the room meta object (the second argument emitted in the stream).

It's created here, on the access check when the room object is fetched.

options.roomParticipant = RocketChat.models.Subscriptions.findOneByRoomIdAndUserId(room._id, this.userId, { fields: { _id: 1 } }) != null;
options.roomType = room.t;
options.roomName = room.name;

I have a fix to get the room object in the original publish method instead. I will submit that now, but this is a pretty critical change and I'd like to understand it and know how it can happen.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions