-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Permalink to direct message shows 404 error page #11400
Copy link
Copy link
Closed
Description
Steps to reproduce:
- Go to any direct message conversation
- Click on the context menu and select "Permalink" to send the link to one of the messages to clipboard
- Send permalink in conversation
- Click on newly linkes message
=> 404 not found
Expected Behavior
Rocket.Chat should follow the link and open the direct message conversation.
Actual behavior:
Rocket.Chat returns 404 error page
Server Setup Information:
- Version of Rocket.Chat Server: 0.65.2
- Operating System: Ubuntu 18.04
- Deployment Method: Docker
- Number of Running Instances: 1
- DB Replicaset Oplog: enabled
- NodeJS Version: dockerized
- MongoDB Version: dockerized
Additional context
Here's a screen capture: https://up.frd.mn/FvXJoCpK8W.mp4
@theorenck commented on Mon Jul 09 2018
I discussed the subject a little with @sampaiodiego and it seems to be a problem with DM permalink's structure, specifically the lack of a proper room name e.g:
- Group: https://open.rocket.chat/channel/general?msg=gxsHQx2cYfQjboWRF
- Direct message: https://open.rocket.chat/direct?msg=QdqwXuafvjn8aQ4sc
The "direct" token is in place of the room name for DM permalinks, which makes the link invalid. We probably need to change this if we want to change the 404 behavior / response.
Reactions are currently unavailable