-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Some i18n.json file name not recognized by tap-i18n #10603
Description
Description:
In latest develop build, at the language selection dropdown, we see some language not recognized by tap-i18n so they are displayed as: lc-CC (for example: vi-VN, th-TH) instead of the human-friendly language name.
AFAIK, tap-i18n uses a language name lookup list to infer the language name. If the i18n.json files are named with unregconized code, the raw file name is displayed instead (so vi-VN.i18n.json -> vi-VN...).
My suggestion is to rename these files to comply with tap-i18n's language table. If this is not possible, maybe we have to add a tap-project.i18n file to list the languages explicitly.
I'm attempting the latter approach in a fork but am getting error with tap-i18n and still figuring how to get it work.
Server Setup Information:
- Version of Rocket.Chat Server: 0.64.0-develop
- Deployment Method(snap/docker/tar/etc): Ubuntu; mannual install
- (others items are not relevant)
Steps to Reproduce:
- Open My Account > Preferences
- Click on the language dropdown at Localization section
- Look for Thai or Vietnamese but get th-TH and vi-VN
Expected behavior:
th-TH should display as Thai; vi-VN should display as Tiếng Việt; etc...
Actual behavior:
Some languages are display with lc-CC instead.
