[IMPROVE] Add agentId parameter to changeLivechatStatus method (#18571)

MartinSchoeler · ggazzo · renatobecker · web-flow · commit dc549a506261 · 2020-08-19T10:27:34.000-03:00
* Add agentId parameter to changeLivechatStatus method

* Fix reviews

* fix problems

* return if the same as before

* Update app/livechat/server/methods/changeLivechatStatus.js

Co-authored-by: Renato Becker &lt;renato.augusto.becker@gmail.com&gt;

* Fix review

Co-authored-by: Guilherme Gazzo &lt;guilhermegazzo@gmail.com&gt;
Co-authored-by: Renato Becker &lt;renato.augusto.becker@gmail.com&gt;
Co-authored-by: Guilherme Gazzo &lt;guilherme@gazzo.xyz&gt;
diff --git a/app/livechat/server/methods/changeLivechatStatus.js b/app/livechat/server/methods/changeLivechatStatus.js
@@ -1,20 +1,45 @@
 import { Meteor } from 'meteor/meteor';
 
 import { Livechat } from '../lib/Livechat';
+import { hasPermission } from '../../../authorization';
+import Users from '../../../models/server/models/Users';
 
 Meteor.methods({
-	'livechat:changeLivechatStatus'() {
-		if (!Meteor.userId()) {
+	'livechat:changeLivechatStatus'({ status, agentId = Meteor.userId() } = {}) {
+		const uid = Meteor.userId();
+
+		if (!uid || !agentId) {
 			throw new Meteor.Error('error-not-allowed', 'Not allowed', { method: 'livechat:changeLivechatStatus' });
 		}
 
-		const user = Meteor.user();
+		const agent = Users.findOneAgentById(agentId, {
+			fields: {
+				status: 1,
+				statusLivechat: 1,
+			},
+		});
+
+		if (!agent) {
+			throw new Meteor.Error('error-not-allowed', 'Not allowed', { method: 'livechat:saveAgentInfo' });
+		}
+
+		const newStatus = status || (agent.statusLivechat === 'available' ? 'not-available' : 'available');
+
+		if (newStatus === agent.statusLivechat) {
+			return;
+		}
+
+		if (agentId !== uid) {
+			if (!hasPermission(uid, 'manage-livechat-agents')) {
+				throw new Meteor.Error('error-not-allowed', 'Not allowed', { method: 'livechat:saveAgentInfo' });
+			}
+			return Livechat.setUserStatusLivechat(agentId, newStatus);
+		}
 
-		const newStatus = user.statusLivechat === 'available' ? 'not-available' : 'available';
-		if (!Livechat.allowAgentChangeServiceStatus(newStatus, user._id)) {
+		if (!Livechat.allowAgentChangeServiceStatus(newStatus, agentId)) {
 			throw new Meteor.Error('error-business-hours-are-closed', 'Not allowed', { method: 'livechat:changeLivechatStatus' });
 		}
 
-		return Livechat.setUserStatusLivechat(user._id, newStatus);
+		return Livechat.setUserStatusLivechat(agentId, newStatus);
 	},
 });
