fix: address CodeRabbit review comments

smirk-dev · smirk-dev · commit d3ccad3d3bf0 · 2026-02-24T09:27:50.000Z
- Add instanceRecord to required array in schema
- Remove nullable: true from optional fields (address, lastHeartbeatTime, local)
- Add success: true to TypeScript generic type
diff --git a/apps/meteor/app/api/server/v1/instances.ts b/apps/meteor/app/api/server/v1/instances.ts
@@ -30,6 +30,7 @@ API.v1.get(
 					instanceRecord: object;
 					broadcastAuth: boolean;
 				}[];
+				success: true;
 			}>({
 				type: 'object',
 				properties: {
@@ -38,20 +39,20 @@ API.v1.get(
 						items: {
 							type: 'object',
 							properties: {
-								address: { type: 'string', nullable: true },
+								address: { type: 'string' },
 								currentStatus: {
 									type: 'object',
 									properties: {
 										connected: { type: 'boolean' },
-										lastHeartbeatTime: { type: 'number', nullable: true },
-										local: { type: 'boolean', nullable: true },
+										lastHeartbeatTime: { type: 'number' },
+										local: { type: 'boolean' },
 									},
 									required: ['connected'],
 								},
 								instanceRecord: { type: 'object' },
 								broadcastAuth: { type: 'boolean' },
 							},
-							required: ['currentStatus', 'broadcastAuth'],
+							required: ['currentStatus', 'instanceRecord', 'broadcastAuth'],
 						},
 					},
 					success: {
