feat(federation): accept remote join at 3rd party

rodrigok · rodrigok · commit a356cfcee0ad · 2025-09-25T18:47:42.000-03:00
diff --git a/ee/packages/federation-matrix/src/events/index.ts b/ee/packages/federation-matrix/src/events/index.ts
@@ -2,7 +2,6 @@ import type { Emitter } from '@rocket.chat/emitter';
 import type { HomeserverEventSignatures } from '@rocket.chat/federation-sdk';
 
 import { edus } from './edu';
-import { invite } from './invite';
 import { member } from './member';
 import { message } from './message';
 import { ping } from './ping';
@@ -16,7 +15,6 @@ export function registerEvents(
 ) {
 	ping(emitter);
 	message(emitter, serverName);
-	invite(emitter);
 	reaction(emitter);
 	member(emitter);
 	edus(emitter, eduProcessTypes);
diff --git a/ee/packages/federation-matrix/src/events/invite.ts b/ee/packages/federation-matrix/src/events/invite.ts
diff --git a/ee/packages/federation-matrix/src/events/member.ts b/ee/packages/federation-matrix/src/events/member.ts
@@ -1,49 +1,102 @@
 import { Room } from '@rocket.chat/core-services';
+import { UserStatus } from '@rocket.chat/core-typings';
 import type { Emitter } from '@rocket.chat/emitter';
 import type { HomeserverEventSignatures } from '@rocket.chat/federation-sdk';
 import { Logger } from '@rocket.chat/logger';
 import { Rooms, Users } from '@rocket.chat/models';
 
 const logger = new Logger('federation-matrix:member');
 
+async function membershipLeaveAction(data: HomeserverEventSignatures['homeserver.matrix.membership']) {
+	const room = await Rooms.findOne({ 'federation.mrid': data.room_id }, { projection: { _id: 1 } });
+	if (!room) {
+		logger.warn(`No bridged room found for Matrix room_id: ${data.room_id}`);
+		return;
+	}
+
+	// state_key is the user affected by the membership change
+	const affectedUser = await Users.findOne({ 'federation.mui': data.state_key });
+	if (!affectedUser) {
+		logger.error(`No Rocket.Chat user found for bridged user: ${data.state_key}`);
+		return;
+	}
+
+	// Check if this is a kick (sender != state_key) or voluntary leave (sender == state_key)
+	if (data.sender === data.state_key) {
+		// Voluntary leave
+		await Room.removeUserFromRoom(room._id, affectedUser);
+		logger.info(`User ${affectedUser.username} left room ${room._id} via Matrix federation`);
+	} else {
+		// Kick - find who kicked
+		const kickerUser = await Users.findOne({ 'federation.mui': data.sender });
+
+		await Room.removeUserFromRoom(room._id, affectedUser, {
+			byUser: kickerUser || { _id: 'matrix.federation', username: 'Matrix User' },
+		});
+
+		const reasonText = data.content.reason ? ` Reason: ${data.content.reason}` : '';
+		logger.info(`User ${affectedUser.username} was kicked from room ${room._id} by ${data.sender} via Matrix federation.${reasonText}`);
+	}
+}
+
+async function membershipJoinAction(data: HomeserverEventSignatures['homeserver.matrix.membership']) {
+	const room = await Rooms.findOne({ 'federation.mrid': data.room_id });
+	if (!room) {
+		console.warn(`No bridged room found for room_id: ${data.room_id}`);
+		return;
+	}
+
+	const internalUsername = data.sender;
+	const localUser = await Users.findOneByUsername(internalUsername);
+	if (localUser) {
+		await Room.addUserToRoom(room._id, localUser);
+		return;
+	}
+
+	const [, serverName] = data.sender.split(':');
+	if (!serverName) {
+		throw new Error('Invalid sender format, missing server name');
+	}
+
+	const { insertedId } = await Users.insertOne({
+		username: internalUsername,
+		type: 'user',
+		status: UserStatus.OFFLINE,
+		active: true,
+		roles: ['user'],
+		name: data.content.displayname || internalUsername,
+		requirePasswordChange: false,
+		createdAt: new Date(),
+		_updatedAt: new Date(),
+		federated: true,
+		federation: {
+			version: 1,
+			mui: data.sender,
+			origin: serverName,
+		},
+	});
+
+	const user = await Users.findOneById(insertedId);
+	if (!user) {
+		console.warn(`User with ID ${insertedId} not found after insertion`);
+		return;
+	}
+	await Room.addUserToRoom(room._id, user);
+}
+
 export function member(emitter: Emitter<HomeserverEventSignatures>) {
 	emitter.on('homeserver.matrix.membership', async (data) => {
 		try {
-			// Only handle leave events (including kicks)
-			if (data.content.membership !== 'leave') {
-				logger.debug(`Ignoring membership event with membership: ${data.content.membership}`);
-				return;
+			if (data.content.membership === 'leave') {
+				return membershipLeaveAction(data);
 			}
 
-			const room = await Rooms.findOne({ 'federation.mrid': data.room_id }, { projection: { _id: 1 } });
-			if (!room) {
-				logger.warn(`No bridged room found for Matrix room_id: ${data.room_id}`);
-				return;
+			if (data.content.membership === 'join') {
+				return membershipJoinAction(data);
 			}
 
-			// state_key is the user affected by the membership change
-			const affectedUser = await Users.findOne({ 'federation.mui': data.state_key });
-			if (!affectedUser) {
-				logger.error(`No Rocket.Chat user found for bridged user: ${data.state_key}`);
-				return;
-			}
+			logger.debug(`Ignoring membership event with membership: ${data.content.membership}`);
 
-			// Check if this is a kick (sender != state_key) or voluntary leave (sender == state_key)
-			if (data.sender === data.state_key) {
-				// Voluntary leave
-				await Room.removeUserFromRoom(room._id, affectedUser);
-				logger.info(`User ${affectedUser.username} left room ${room._id} via Matrix federation`);
-			} else {
-				// Kick - find who kicked
-				const kickerUser = await Users.findOne({ 'federation.mui': data.sender });
-
-				await Room.removeUserFromRoom(room._id, affectedUser, {
-					byUser: kickerUser || { _id: 'matrix.federation', username: 'Matrix User' },
-				});
-
-				const reasonText = data.content.reason ? ` Reason: ${data.content.reason}` : '';
-				logger.info(`User ${affectedUser.username} was kicked from room ${room._id} by ${data.sender} via Matrix federation.${reasonText}`);
-			}
 		} catch (error) {
 			logger.error('Failed to process Matrix membership event:', error);
 		}
