Skip to content

Commit 2e5417c

Browse files
committed
Merge branch 'ref/omni-curr-chats' of github.com:RocketChat/Rocket.Chat into ref/omni-curr-chats
2 parents da8388b + 6b04ba5 commit 2e5417c

File tree

65 files changed

+6585
-9898
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

65 files changed

+6585
-9898
lines changed

.github/issue-close-app.yml

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,14 @@
11
# Config for Close Issue app: https://probot.github.io/apps/close-issue/
22

33
# Comment that will be sent if an issue is judged to be closed
4-
comment: |
5-
This issue was closed because it does not use our bug report issue template.
6-
7-
Please make sure to use it and fill it as much as you can so we can provide better and faster support.
8-
9-
The following sections **must not** be removed, or else the BOT will close it immediately again:
10-
11-
* Steps to reproduce
12-
* Expected behavior
13-
* Actual behavior
14-
* Server Setup Information
4+
comment: "This issue was closed because it does not use any of our issue templates. Please make sure to use one of the suggested templates."
155
issueConfigs:
166
# There can be several configs for different kind of issues.
177
- content:
188
# Bug report
199
- "Steps to reproduce"
2010
- "Expected behavior"
2111
- "Actual behavior"
22-
- "Server Setup Information"
2312
- "Version of Rocket.Chat Server"
2413
- content:
2514
# Release issue

.github/workflows/build_and_test.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -238,9 +238,7 @@ jobs:
238238
MONGO_URL: mongodb://localhost:27017/rocketchat
239239
MONGO_OPLOG_URL: mongodb://localhost:27017/local
240240
run: |
241-
echo -e 'pcm.!default {\n type hw\n card 0\n}\n\nctl.!default {\n type hw\n card 0\n}' > ~/.asoundrc
242-
Xvfb -screen 0 1024x768x24 :99 &
243-
for i in $(seq 1 5); do (docker exec mongo mongo rocketchat --eval 'db.dropDatabase()') && npm run testci && s=0 && break || s=$? && sleep 1; done; (exit $s)
241+
for i in $(seq 1 5); do (docker exec mongo mongo rocketchat --eval 'db.dropDatabase()') && xvfb-run --auto-servernum npm run testci && s=0 && break || s=$? && sleep 1; done; (exit $s)
244242
245243
# notification:
246244
# runs-on: ubuntu-latest

app/authentication/server/startup/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ Accounts.onCreateUser(function(options, user = {}) {
153153
callbacks.run('beforeCreateUser', options, user);
154154

155155
user.status = 'offline';
156-
user.active = user.active !== undefined ? user.active : !settings.get('Accounts_ManuallyApproveNewUsers');
156+
user.active = !settings.get('Accounts_ManuallyApproveNewUsers');
157157

158158
if (!user.name) {
159159
if (options.profile) {

app/authorization/client/views/permissions.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import { hasAllPermission } from '../hasPermission';
1111
import { t } from '../../../utils/client';
1212
import { SideNav } from '../../../ui-utils/client/lib/SideNav';
1313
import { CONSTANTS, AuthorizationUtils } from '../../lib';
14+
1415
import { hasAtLeastOnePermission } from '..';
1516

1617
Template.permissions.helpers({

app/authorization/server/startup.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ Meteor.startup(function() {
2424
{ _id: 'assign-roles', roles: ['admin'] },
2525
{ _id: 'ban-user', roles: ['admin', 'owner', 'moderator'] },
2626
{ _id: 'bulk-register-user', roles: ['admin'] },
27-
{ _id: 'change-livechat-room-visitor', roles: ['admin', 'livechat-manager', 'livechat-agent'] },
2827
{ _id: 'create-c', roles: ['admin', 'user', 'bot', 'app'] },
2928
{ _id: 'create-d', roles: ['admin', 'user', 'bot', 'app'] },
3029
{ _id: 'create-p', roles: ['admin', 'user', 'bot', 'app'] },

app/autotranslate/server/methods/getSupportedLanguages.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { Meteor } from 'meteor/meteor';
22
import { DDPRateLimiter } from 'meteor/ddp-rate-limiter';
33

44
import { hasPermission } from '../../../authorization';
5+
56
import { TranslationProviderRegistry } from '..';
67

78
Meteor.methods({

app/autotranslate/server/methods/translateMessage.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { Meteor } from 'meteor/meteor';
22

33
import { Rooms } from '../../../models';
4+
45
import { TranslationProviderRegistry } from '..';
56

67
Meteor.methods({

app/e2e/client/rocketchat.e2e.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -481,10 +481,8 @@ class E2E {
481481
}
482482

483483
closeAlert() {
484-
if (showingE2EAlert) {
485-
alerts.close();
486-
}
487484
showingE2EAlert = false;
485+
alerts.close();
488486
}
489487
}
490488

app/importer/server/methods/downloadPublicImportFile.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import { Meteor } from 'meteor/meteor';
77
import { RocketChatImportFileInstance } from '../startup/store';
88
import { ProgressStep } from '../../lib/ImporterProgressStep';
99
import { hasPermission } from '../../../authorization';
10+
1011
import { Importers } from '..';
1112

1213
function downloadHttpFile(fileUrl, writeStream) {

0 commit comments

Comments
 (0)