Prefer assertion

tassoevan · tassoevan · commit 08e8a58fcb30 · 2022-02-21T21:08:34.000-03:00
diff --git a/client/views/room/threads/ThreadComponent.tsx b/client/views/room/threads/ThreadComponent.tsx
@@ -63,7 +63,7 @@ const ThreadComponent: FC<{
 	onClickBack: (e: unknown) => void;
 }> = ({ mid, jump, room, onClickBack }) => {
 	const subscription = useUserSubscription(room._id, subscriptionFields);
-	const channelRoute = useRoute(roomCoordinator.getRoomTypeConfig(room.t)?.route?.name as string);
+	const channelRoute = useRoute(roomCoordinator.getRoomTypeConfig(room.t).route.name);
 	const threadMessage = useThreadMessage(mid);
 
 	const openUserInfo = useTabBarOpenUserInfo();
diff --git a/lib/rooms/coordinator.ts b/lib/rooms/coordinator.ts
@@ -108,8 +108,12 @@ export abstract class RoomCoordinator {
 		return undefined;
 	}
 
-	getRoomTypeConfig(identifier: string): IRoomTypeConfig | undefined {
-		return this.roomTypes[identifier]?.config;
+	getRoomTypeConfig(identifier: string): IRoomTypeConfig {
+		if (!this.roomTypes[identifier]) {
+			throw new Error(`Room type with identifier ${identifier} does not exist.`);
+		}
+
+		return this.roomTypes[identifier].config;
 	}
 
 	getRouteLink(roomType: string, subData: RoomIdentification): string | false {

Original file line number	Diff line number	Diff line change
`@@ -108,8 +108,12 @@ export abstract class RoomCoordinator {`
`108`	`108`	`return undefined;`
`109`	`109`	`}`
`110`	`110`
`111`		`- getRoomTypeConfig(identifier: string): IRoomTypeConfig \| undefined {`
`112`		`- return this.roomTypes[identifier]?.config;`
	`111`	`+ getRoomTypeConfig(identifier: string): IRoomTypeConfig {`
	`112`	`+ if (!this.roomTypes[identifier]) {`
	`113`	+ throw new Error(`Room type with identifier ${identifier} does not exist.`);
	`114`	`+ }`
	`115`	`+`
	`116`	`+ return this.roomTypes[identifier].config;`
`113`	`117`	`}`
`114`	`118`
`115`	`119`	`getRouteLink(roomType: string, subData: RoomIdentification): string \| false {`