refactor: migrate rooms.delete endpoint to new API format

Rohitgiri02 · Rohitgiri02 · commit 02630d2d2694 · 2026-02-08T07:01:41.000Z
- Replace deprecated addRoute with chained .post() method
- Add body validation using ajv.compile for roomId
- Add response schemas for 200, 400, 401 status codes
- Register types via ExtractRoutesFromAPI and declare module
- Enable automatic OpenAPI spec generation for rooms.delete
diff --git a/apps/meteor/app/api/server/v1/rooms.ts b/apps/meteor/app/api/server/v1/rooms.ts
@@ -121,37 +121,58 @@ API.v1.addRoute(
 	},
 );
 
-API.v1.addRoute(
+const roomDeleteEndpoint = API.v1.post(
 	'rooms.delete',
 	{
 		authRequired: true,
+		body: ajv.compile<{ roomId: string }>({
+			type: 'object',
+			properties: {
+				roomId: {
+					type: 'string',
+					description: 'The ID of the room to delete.',
+				},
+			},
+			required: ['roomId'],
+			additionalProperties: false,
+		}),
+		response: {
+			200: ajv.compile<void>({
+				type: 'object',
+				properties: {
+					success: {
+						type: 'boolean',
+						enum: [true],
+						description: 'Indicates if the request was successful.',
+					},
+				},
+				required: ['success'],
+				additionalProperties: false,
+			}),
+			400: validateBadRequestErrorResponse,
+			401: validateUnauthorizedErrorResponse,
+		},
 	},
-	{
-		async post() {
-			const { roomId } = this.bodyParams;
-
-			if (!roomId) {
-				return API.v1.failure("The 'roomId' param is required");
-			}
+	async function action() {
+		const { roomId } = this.bodyParams;
 
-			const room = await Rooms.findOneById(roomId);
+		const room = await Rooms.findOneById(roomId);
 
-			if (!room) {
-				throw new MeteorError('error-invalid-room', 'Invalid room', {
-					method: 'eraseRoom',
-				});
-			}
+		if (!room) {
+			throw new MeteorError('error-invalid-room', 'Invalid room', {
+				method: 'eraseRoom',
+			});
+		}
 
-			if (room.teamMain) {
-				throw new Meteor.Error('error-cannot-delete-team-channel', 'Cannot delete a team channel', {
-					method: 'eraseRoom',
-				});
-			}
+		if (room.teamMain) {
+			throw new Meteor.Error('error-cannot-delete-team-channel', 'Cannot delete a team channel', {
+				method: 'eraseRoom',
+			});
+		}
 
-			await eraseRoom(room, this.user);
+		await eraseRoom(room, this.user);
 
-			return API.v1.success();
-		},
+		return API.v1.success();
 	},
 );
 
@@ -1098,7 +1119,9 @@ const roomInviteEndpoints = API.v1.post(
 	},
 );
 
-type RoomEndpoints = ExtractRoutesFromAPI<typeof roomEndpoints> & ExtractRoutesFromAPI<typeof roomInviteEndpoints>;
+type RoomEndpoints = ExtractRoutesFromAPI<typeof roomEndpoints> &
+	ExtractRoutesFromAPI<typeof roomInviteEndpoints> &
+	ExtractRoutesFromAPI<typeof roomDeleteEndpoint>;
 
 declare module '@rocket.chat/rest-typings' {
 	// eslint-disable-next-line @typescript-eslint/naming-convention, @typescript-eslint/no-empty-interface
diff --git a/packages/rest-typings/src/v1/rooms.ts b/packages/rest-typings/src/v1/rooms.ts
@@ -825,10 +825,6 @@ export type RoomsEndpoints = {
 		};
 	};
 
-	'/v1/rooms.delete': {
-		POST: (params: { roomId: string }) => void;
-	};
-
 	'/v1/rooms.get': {
 		GET: (params: { updatedSince: string }) => {
 			update: IRoom[];
