Skip to content

[Feat] Notion Authorization with Rocket.Chat#5

Merged
samad-yar-khan merged 29 commits intoRocketChat:mainfrom
Nabhag8848:feat/NotionSDK
Jun 21, 2023
Merged

[Feat] Notion Authorization with Rocket.Chat#5
samad-yar-khan merged 29 commits intoRocketChat:mainfrom
Nabhag8848:feat/NotionSDK

Conversation

@Nabhag8848
Copy link
Collaborator

@Nabhag8848 Nabhag8848 commented Jun 3, 2023

Issue(s)

Acceptance Criteria fulfillment

  • Create Setting for Credentials (SettingType STRING - ClientId, SettingType PASSWORD Client Secret).
  • Register Command with params connect and disconnect.
  • Create NotionSDK Class
  • Create WebHookEndpoint for handling Notion Callback
  • Create Function to getTokenInfo else Send Relevant Notification with Connect to Workspace button alerting user not connected.
  • Send Relevant Notification to Channel including Message from MessageBuilder when there is complete execution.
  • Create MessageBuilder with Button (only in case of connect)

Proposed changes (including videos or screenshots)

Further comments

  • Create CustomError Class extending which have CommonError class
  • Use Integration SVG in Authorization HTML page.
  • Handle Empty Credentials and give Notification to channel as per user Roles.

Edge Cases

  • When User Changes State in AuthURL
  • When User Leaves in Between Auth
  • When User Cancel the Auth but Go Back to AuthURL pressing <— in Browser
  • When User runs connect command in two channels [Say first and Second] one by one during session and connects from First Message should go to First and so on.
  • When There is Problem from Notion Provider to Generate Token
  • Using feat with multiple user.
  • Handle Empty Credentials and give Notification to channel as per user Roles.

Nabhag8848 added 23 commits June 3, 2023 11:41
@Nabhag8848 Nabhag8848 marked this pull request as ready for review June 6, 2023 07:14
@Nabhag8848 Nabhag8848 marked this pull request as draft June 6, 2023 17:33
@Nabhag8848 Nabhag8848 marked this pull request as ready for review June 7, 2023 11:00
Copy link
Collaborator

@samad-yar-khan samad-yar-khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samad-yar-khan samad-yar-khan merged commit e8cecc6 into RocketChat:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat] Notion Authorization with Rocket.Chat

2 participants