[Feat] Create Notion Record From RC#22
Conversation
Nabhag8848
force-pushed
the
feat/create-record-with-multiselect-prop
branch
from
f632af6 to
e089eec
Compare
samad-yar-khan
left a comment
samad-yar-khan
left a comment
There was a problem hiding this comment.
@Nabhag8848 left some comments
| ADD_PROPERTY_ACTION = "add-property-create-page-or-record-action-id", | ||
| ADD_PROPERTY_BLOCK = "add-property-create-page-or-record-action-id", | ||
| ADD_PROPERTY_BUTTON_TEXT = "Add Property", |
There was a problem hiding this comment.
Nope! these are not needed as we had transition to new implementation. before it was having add and remove but now we just get all the components as user selects notion table.
| ); | ||
| ]; | ||
|
|
||
| const missingObject = {}; |
There was a problem hiding this comment.
Renamed to missingPropObject to make it more meaningful. its being used for view errors when user misses the required property to input.
Related to #22 (comment)
| missingObject[ | ||
| NotionPageOrRecord.TITLE_ACTION | ||
| ] = `Please Provide ${titleViewError}`; |
There was a problem hiding this comment.
I have used assignment immutablity in this case. const missingObject = { } is making sure reference to that object doesn't change.
Just shared the below example showing what i mean.
we can see object1 has also been changed due to change in missingObject as we have a constant reference when changing its changing the existing object not the referrence.
2 participants
Issue(s)
Acceptance Criteria fulfillment
Proposed changes (including videos or screenshots)
Further comments