[Feat] Create Notion Page From RocketChat#20
Merged
samad-yar-khan merged 12 commits intoRocketChat:mainfrom Aug 20, 2023
Merged
[Feat] Create Notion Page From RocketChat#20samad-yar-khan merged 12 commits intoRocketChat:mainfrom
samad-yar-khan merged 12 commits intoRocketChat:mainfrom
Conversation
5 tasks
description: currently this contains just the implementation of creation of page and doesn't include the complete implementation when database selected
description: handleCreationOfRecord is not implemented which will be done in addup PR but note that this doesnt contain viewErrors as well,see you soon
Nabhag8848
force-pushed
the
feat/create-record-page
branch
from
d4e077a to
5899266
Compare
samad-yar-khan
approved these changes
Aug 20, 2023
Collaborator
samad-yar-khan
left a comment
samad-yar-khan
left a comment
There was a problem hiding this comment.
LGTM @Nabhag8848
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s)
Acceptance Criteria fulfillment
/notion createcommandProposed changes (including videos or screenshots)
Further comments