[Feat] Provide Helper Message OnInstallation of App#18
Merged
samad-yar-khan merged 2 commits intoRocketChat:mainfrom Aug 5, 2023
Merged
[Feat] Provide Helper Message OnInstallation of App#18samad-yar-khan merged 2 commits intoRocketChat:mainfrom
samad-yar-khan merged 2 commits intoRocketChat:mainfrom
Conversation
Collaborator
|
@Nabhag8848 Can you please fix these conflicts |
description: Created getOrCreateDirectRoom Method for targetRoom and HelperMessage is Persistant, Will Only Get to Installer.
Nabhag8848
force-pushed
the
feat/OnInstall
branch
from
8d91a28 to
0783213
Compare
Collaborator
Author
Done. Thanks. |
samad-yar-khan
approved these changes
Aug 5, 2023
Collaborator
samad-yar-khan
left a comment
samad-yar-khan
left a comment
There was a problem hiding this comment.
@Nabhag8848 Looks Good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s)
Acceptance Criteria fulfillment
Proposed changes (including videos or screenshots)
Further comments