[Feat] Create Notion Database From RocketChat For Properties Includes Configuration by Nabhag8848 · Pull Request #15 · RocketChat/Apps.Notion

Nabhag8848 · 2023-06-19T07:52:04Z

Issue(s)

Closes [Feat] Create Notion Database From RocketChat #6 and addition to [Feat] Create Notion Database From RocketChat For Properties Without Configuration #14

Acceptance Criteria fulfillment

Created Dispatch Actions for Property Type Select, MultiSelect, Formula and Number
Updates Modal as Per the Selection of Property Type and Has Additional Configuration Elements When Required.
Handle Missing Properties With and Without Having Configuration [ViewErrors]
Handle Duplicate Property Name with ViewErrors.
Fix Return type of CreateNotionDatabase method under NotionSDK to have INotionDatabase as Return Type.
Configured Notification of Creation of Database iin Channel to Have the Table as Attachments showing the Database created propertyName and PropertyType.

Proposed changes (including videos or screenshots)

Further comments

…mula Prop

… and multiselect

…ration

samad-yar-khan

@Nabhag8848 A few comments to improve code maintainability.

samad-yar-khan · 2023-07-09T15:00:44Z

enum/modals/common/NotionProperties.ts

+export enum Number {
+    NUMBER = "number",
+    NUMBER_WITH_COMMAS = "number_with_commas",
+    PERCENT = "percent",
+    DOLLAR = "dollar",
+    CANADIAN_DOLLAR = "canadian_dollar",
+    EURO = "euro",
+    POUND = "pound",
+    YEN = "yen",
+    RUBLE = "ruble",
+    RUPEE = "rupee",
+    WON = "won",
+    YUAN = "yuan",
+    REAL = "real",
+    LIRA = "lira",
+    RUPIAH = "rupiah",
+    FRANC = "franc",
+    HONG_KONG_DOLLAR = "hong_kong_dollar",
+    NEW_ZEALAND_DOLLAR = "new_zealand_dollar",
+    KRONA = "krona",
+    NORWEGIAN_KRONE = "norwegian_krone",
+    MEXICAN_PESO = "mexican_peso",
+    RAND = "rand",
+    NEW_TAIWAN_DOLLAR = "new_taiwan_dollar",
+    DANISH_KRONE = "danish_krone",
+    ZLOTY = "zloty",
+    BAHT = "baht",
+    FORINT = "forint",
+    KORUNA = "koruna",
+    SHEKEL = "shekel",


@Nabhag8848 It may be hard to maintain these if there are changes in notion itself.

Yep, @samad-yar-khan pretty hard. I just check out the changelog and there are changes to it on 3 different releases before.

Between April - May-2023

Between Oct-Nov-2022

In July 2021

Notion doesn't provide an endpoint to retrieve the available format of Number, format/available value for Notion types having configuration.

Is there any other way we can improve this and make it more managable? i think in this case enum would be more managable as, if there are changes we just need to add the change in enum folder.

samad-yar-khan · 2023-07-09T15:01:44Z

src/handlers/ExecuteBlockActionHandler.ts

+                const dispatchActionConfig = dispatchActionPropertyType
+                    ? DatabaseModal.PROPERTY_TYPE_SELECT_ACTION
+                    : dispatchActionPropertyName
+                    ? DatabaseModal.PROPERTY_NAME_ACTION
+                    : dispatchActionSelectOptionName
+                    ? DatabaseModal.SELECT_PROPERTY_OPTION_NAME
+                    : null;


@Nabhag8848 Can we make this more readable ?

yep, done with this one.

src/handlers/ExecuteBlockActionHandler.ts

Nabhag8848 · 2023-07-11T10:31:27Z

src/lib/NotionSDK.ts

Untitled pageName was causing an UnHandledPromiseRejection in Server which i had fixed later, but as we are making changes i did fix this here.

Nabhag8848 · 2023-07-11T10:33:40Z

enum/CommandParam.ts

 }

 export enum SubCommandParam {
-    DATABASE = "database",
+    DATABASE = "db",
 }


Made the sub command param to db which was discussed previously.

Nabhag8848 · 2023-07-11T11:24:39Z

src/handlers/ExecuteBlockActionHandler.ts

                // Property Type Select Action
-                const dispatchActionPropertyType = actionId.startsWith(
-                    DatabaseModal.PROPERTY_TYPE_SELECT_ACTION
-                );
+                const propertyTypeSelected =
+                    DatabaseModal.PROPERTY_TYPE_SELECT_ACTION.toString();
+                const isPropertyTypeDispatchAction =
+                    actionId.startsWith(propertyTypeSelected);

                // Property Name Character Entered Action
-                const dispatchActionPropertyName =
-                    actionId.startsWith(DatabaseModal.PROPERTY_NAME_ACTION) ||
-                    actionId.startsWith(DatabaseModal.TITLE_PROPERTY_ACTION);
+                const propertyNameEntered =
+                    DatabaseModal.PROPERTY_NAME_ACTION.toString();
+
+                const titlePropertyNameEntered =
+                    DatabaseModal.TITLE_PROPERTY_ACTION.toString();
+
+                const isPropertyNameDispatchAction =
+                    actionId.startsWith(propertyNameEntered) ||
+                    actionId.startsWith(titlePropertyNameEntered);

                // Property Type Select Option Name Action
-                const dispatchActionSelectOptionName = blockId.startsWith(
-                    DatabaseModal.PROPERTY_TYPE_SELECT_BLOCK
+
+                const SelectPropertyOptionNameAction =
+                    DatabaseModal.PROPERTY_TYPE_SELECT_BLOCK.toString();
+
+                const SelectPropertyOptionNameEntered =
+                    DatabaseModal.SELECT_PROPERTY_OPTION_NAME.toString();
+
+                const isSelectOptionNameDispatchAction = blockId.startsWith(
+                    SelectPropertyOptionNameAction
                );

-                const dispatchActionConfig = dispatchActionPropertyType
-                    ? DatabaseModal.PROPERTY_TYPE_SELECT_ACTION
-                    : dispatchActionPropertyName
-                    ? DatabaseModal.PROPERTY_NAME_ACTION
-                    : dispatchActionSelectOptionName
-                    ? DatabaseModal.SELECT_PROPERTY_OPTION_NAME
+                const typeOfActionOccurred = isPropertyTypeDispatchAction
+                    ? propertyTypeSelected
+                    : isPropertyNameDispatchAction
+                    ? propertyNameEntered
+                    : isSelectOptionNameDispatchAction
+                    ? SelectPropertyOptionNameEntered
                    : null;

-                switch (dispatchActionConfig) {
+                switch (typeOfActionOccurred) {
                    case DatabaseModal.PROPERTY_TYPE_SELECT_ACTION: {
                        this.handlePropertyTypeSelectAction(


Fixed Variable Naming

Nabhag8848 mentioned this pull request Jun 27, 2023

[Feat] Create Notion Database From RocketChat #6

Closed

12 tasks

Nabhag8848 marked this pull request as ready for review June 27, 2023 06:38

Nabhag8848 added 12 commits July 8, 2023 11:18

feat: created dispatchAction of adding Format Dropdown on Number Prop

c5a4153

feat: created dispatchAction of adding Expression InputElement on For…

2293d34

…mula Prop

feat: created dispatchAction of adding and removing options of select…

21c9f30

… and multiselect

feat: created handler for Missing Properties with and without configu…

88f0446

…ration

feat: created NotionDatabaseObject for properties includes configuration

f6ad2f4

fix: handled duplicate property name with view Errors

c61fb5c

fix: ViewError Messages that doesn't support markdown

bc465cc

fix: whitespaces string doesn't giving duplicacy of property name

e3afc36

fix: create Database Modal responding with Unneccasary ViewError

92c93ec

fix: all Edge cases of Duplicate PropertyName Viewerrors

4b744de

fix: createNotionDatabase() in SDK to have INotionDatabase return type

a255094

feat(enhance): creation Database Notification with Table as Attachment

97137a6

Nabhag8848 force-pushed the feat/create-db-with-config branch from 0d5a997 to 97137a6 Compare July 8, 2023 05:51

samad-yar-khan requested changes Jul 9, 2023

View reviewed changes

Nabhag8848 added 3 commits July 11, 2023 15:07

fix: conditions involving operators to variables

ae6f23f

fix: command param database to db for quick access

884e3b8

fix: Untitled pageName causing UnHandledPromiseRejection

c3f5e39

Nabhag8848 commented Jul 11, 2023

View reviewed changes

fix: block DispatchActions conditions to have readable variable names

2bf2956

Nabhag8848 commented Jul 11, 2023

View reviewed changes

Nabhag8848 requested a review from samad-yar-khan July 11, 2023 11:26

samad-yar-khan merged commit b1f10c5 into RocketChat:main Jul 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feat] Create Notion Database From RocketChat For Properties Includes Configuration#15

[Feat] Create Notion Database From RocketChat For Properties Includes Configuration#15
samad-yar-khan merged 16 commits intoRocketChat:mainfrom
Nabhag8848:feat/create-db-with-config

Nabhag8848 commented Jun 19, 2023 •

edited

Loading

Uh oh!

samad-yar-khan left a comment •

edited

Loading

Uh oh!

samad-yar-khan Jul 9, 2023

Uh oh!

Nabhag8848 Jul 10, 2023

Uh oh!

samad-yar-khan Jul 9, 2023

Uh oh!

Nabhag8848 Jul 11, 2023

Uh oh!

Uh oh!

Uh oh!

Nabhag8848 Jul 11, 2023

Uh oh!

Nabhag8848 Jul 11, 2023

Uh oh!

Nabhag8848 Jul 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Nabhag8848 commented Jun 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue(s)

Acceptance Criteria fulfillment

Proposed changes (including videos or screenshots)

Further comments

Uh oh!

samad-yar-khan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

samad-yar-khan Jul 9, 2023

Choose a reason for hiding this comment

Uh oh!

Nabhag8848 Jul 10, 2023

Choose a reason for hiding this comment

Uh oh!

samad-yar-khan Jul 9, 2023

Choose a reason for hiding this comment

Uh oh!

Nabhag8848 Jul 11, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Nabhag8848 Jul 11, 2023

Choose a reason for hiding this comment

Uh oh!

Nabhag8848 Jul 11, 2023

Choose a reason for hiding this comment

Uh oh!

Nabhag8848 Jul 11, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Nabhag8848 commented Jun 19, 2023 •

edited

Loading

samad-yar-khan left a comment •

edited

Loading