Skip to content

Fix some brittle snapshots based on github api responses#74

Merged
ZoteTheMighty merged 1 commit intomainfrom
nojira-fix-snapshots
Jul 18, 2023
Merged

Fix some brittle snapshots based on github api responses#74
ZoteTheMighty merged 1 commit intomainfrom
nojira-fix-snapshots

Conversation

@ZoteTheMighty
Copy link
Contributor

Updates snapshot tests, should unblock #71

@ZoteTheMighty
Copy link
Contributor Author

@matthargett I can't formally request you as a reviewer, but merging this and updating #71 should unblock its CI so we can get it in.

@matthargett
Copy link
Contributor

@matthargett I can't formally request you as a reviewer, but merging this and updating #71 should unblock its CI so we can get it in.

I approved, but it looks like is still needs another review somehow?

Copy link
Contributor

@matthargett matthargett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ZoteTheMighty ZoteTheMighty merged commit 55e2fba into main Jul 18, 2023
@ZoteTheMighty ZoteTheMighty deleted the nojira-fix-snapshots branch July 18, 2023 16:36
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants