express-zod-api/bench/experiment.bench.ts (1)

47-55: Keep schema construction and early-exit input out of the benchmark hot path.

Right now each iteration measures z.custom() construction plus a parse that fails on the first missing key. Pre-create the schemas and parse a full upload-shaped object to measure the validation path being refactored.

Proposed benchmark adjustment

+  const validUpload = {
+    name: "avatar.jpg",
+    encoding: "utf-8",
+    mimetype: "image/jpeg",
+    data: Buffer.from("something"),
+    tempFilePath: "",
+    truncated: false,
+    size: 100500,
+    md5: "",
+    mv: () => {},
+  };
+
+  const currentSchema = current();
+  const featuredSchema = featured();
+
   bench("current", () => {
-    const one = current();
-    one.safeParse({});
+    currentSchema.safeParse(validUpload);
   });
 
   bench("featured", () => {
-    const one = featured();
-    one.safeParse({});
+    featuredSchema.safeParse(validUpload);
   });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@express-zod-api/bench/experiment.bench.ts` around lines 47 - 55, The
benchmark currently constructs the schemas and parses an empty object inside
each bench iteration, measuring z.custom() creation and an early-failing parse;
move schema construction out of the hot path by calling current() and featured()
once before the bench declarations and reuse their returned schema objects
inside the bench callbacks (referencing current() and featured()), and replace
the empty input with a complete "upload-shaped" object that exercises the full
validation path so safeParse(...) validates actual upload data rather than
failing fast.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

• Read the PR diff and understand the changes
• Read the changed source files for full context
• Trace data flow and verify correctness of refactoring
• Self-critique drafted comments
• Submit review

• Read the PR diff and understand the changes
• Read the changed source files for full context
• Trace data flow and verify correctness of refactoring
• Self-critique drafted comments
• Submit review

express-zod-api/tests/upload-schema.spec.ts (1)

26-38: ⚠️ Potential issue | 🟡 Minor

Keep the deletion fixture type-safe.

input is inferred with required properties, so delete input[key] can fail strict TypeScript checks. Mark the fixture partial before deleting. Based on learnings, strict: true enables strict null checking and related strict type-checking behavior.

Proposed fix

-      const input = {
+      const input: Partial<Record<typeof key, null>> = {
         name: null,
         encoding: null,
         mimetype: null,
         data: null,
         tempFilePath: null,
         truncated: null,
         size: null,
         md5: null,
         mv: null,
       };

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@express-zod-api/tests/upload-schema.spec.ts` around lines 26 - 38, The test
fixture `input` is currently inferred with all required properties so `delete
input[key]` violates strict TypeScript checks; change the fixture's type to a
partial type (e.g., declare `input` as Partial<typeof input>` or
`Partial<Upload>`/`Partial<Record<...>>`) or cast it to a writable partial
before deleting so the `delete input[key]` operation is type-safe; update the
test that uses `isObjectOfUploadShape` to use this partial-typed `input`
variable so the deletion compiles under `strict: true`.