Skip to content

Readme: rm units from contributor img attributes#3078

Merged
RobinTail merged 1 commit intomasterfrom
fix-redundant-unit
Nov 21, 2025
Merged

Readme: rm units from contributor img attributes#3078
RobinTail merged 1 commit intomasterfrom
fix-redundant-unit

Conversation

@RobinTail
Copy link
Copy Markdown
Owner

@RobinTail RobinTail commented Nov 21, 2025 •
edited by coderabbitai Bot
Loading

Proof https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/img
Related to #3077

Summary by CodeRabbit

  • Style
    • Updated the Contributors section with adjusted list formatting and contributor avatar sizing for improved display consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

@RobinTail RobinTail added documentation Improvements or additions to documentation prevention labels Nov 21, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 21, 2025 •
edited
Loading

Walkthrough

Cosmetic formatting updates to contributor lists in README.md and tools/contributors.ts, including markdown list prefix changes and image width attribute adjustments from 50px to 50, with no functional logic modifications.

Changes

Cohort / File(s) Summary
Contributor list formatting
README.md, tools/contributors.ts		 Changed markdown list item prefixes from - to + and modified image width attributes from 50px to 50 in contributor avatar tags

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • These changes are purely cosmetic and display-oriented
  • No logic, data flow, or API modifications
  • Straightforward attribute and formatting updates with minimal cognitive overhead

Poem

🐰 A little tweak here, a format there,
List items dance through the contributors' air!
Fifty pixels shrink to fifty more,
Prettier avatars than before! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: removing units (px) from contributor image width attributes in README and related files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-redundant-unit
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c6a861 and 38f3ce5.

📒 Files selected for processing (2)
  • README.md (1 hunks)
  • tools/contributors.ts (1 hunks)
🔇 Additional comments (2)
tools/contributors.ts (1)

13-13: LGTM! Corrects invalid HTML.

The width attribute in HTML <img> elements should be a unitless integer representing pixels, not include "px" explicitly.

README.md (1)

89-143: LGTM! HTML attributes corrected.

All contributor avatar images now use valid HTML with unitless width attributes as required by the spec.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@RobinTail RobinTail marked this pull request as ready for review November 21, 2025 20:18
@coveralls-official
Copy link
Copy Markdown

coveralls-official Bot commented Nov 21, 2025

Coverage Status

coverage: 100.0%. remained the same
when pulling 38f3ce5 on fix-redundant-unit
into 3c6a861 on master.

@RobinTail RobinTail merged commit 5656376 into master Nov 21, 2025
13 checks passed
@RobinTail RobinTail deleted the fix-redundant-unit branch November 21, 2025 20:30
@coderabbitai coderabbitai Bot mentioned this pull request Nov 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation prevention

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@RobinTail