Skip to content

Add engine restrictions to migration package#3066

Merged
RobinTail merged 1 commit intomasterfrom
add-engines-migration
Nov 15, 2025
Merged

Add engine restrictions to migration package#3066
RobinTail merged 1 commit intomasterfrom
add-engines-migration

Conversation

@RobinTail
Copy link
Copy Markdown
Owner

@RobinTail RobinTail commented Nov 15, 2025 •
edited by coderabbitai Bot
Loading

Need this for consistency and proper tsdown build

Summary by CodeRabbit

  • Chores
    • Updated Node.js version compatibility requirements for the migration package to support versions ^20.19.0, ^22.12.0, and ^24.0.0.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 15, 2025 •
edited
Loading

Walkthrough

Added a Node.js version constraint to the migration package's package.json file specifying support for versions ^20.19.0, ^22.12.0, or ^24.0.0. This single configuration field addition restricts which Node.js runtime versions can execute the migration package.

Changes

Cohort / File(s) Summary
Migration package configuration
migration/package.json		 Added engines field specifying Node.js version requirements: `^20.19.0

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

breaking

Poem

🐰 A rabbit hops through version lands,
Setting boundaries with careful hands—
Node twenty, twenty-two, and four,
The migration path now has a door!
No older versions shall pass through,
Fresh engines make the package new! 🚀

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main change: adding engine restrictions (Node.js version constraints) to the migration package.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add-engines-migration
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1bce19c and 0d5c37c.

📒 Files selected for processing (1)
  • migration/package.json (1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings 
Learnt from: RobinTail
Repo: RobinTail/express-zod-api PR: 2974
File: migration/tsconfig.json:2-2
Timestamp: 2025-09-29T06:06:58.605Z
Learning: tsconfig/node20 includes "moduleResolution": "node16" in its base configuration, along with other settings like "module": "nodenext", "target": "es2022", and "strict": true. When extending from tsconfig/node20, explicit moduleResolution configuration is not needed.

Learnt from: RobinTail
Repo: RobinTail/express-zod-api PR: 2974
File: migration/tsconfig.json:2-2
Timestamp: 2025-09-29T06:06:58.605Z
Learning: tsconfig/node20 includes "moduleResolution": "node16" in its base configuration, along with other settings. When extending from tsconfig/node20, explicit moduleResolution configuration is not needed as it's provided by the preset.
📚 Learning: 2025-09-29T06:06:58.605Z 
Learnt from: RobinTail
Repo: RobinTail/express-zod-api PR: 2974
File: migration/tsconfig.json:2-2
Timestamp: 2025-09-29T06:06:58.605Z
Learning: tsconfig/node20 includes "moduleResolution": "node16" in its base configuration, along with other settings like "module": "nodenext", "target": "es2022", and "strict": true. When extending from tsconfig/node20, explicit moduleResolution configuration is not needed.

Applied to files:

  • migration/package.json
📚 Learning: 2025-09-29T06:00:16.488Z 
Learnt from: RobinTail
Repo: RobinTail/express-zod-api PR: 2974
File: express-zod-api/src/documentation-helpers.ts:48-48
Timestamp: 2025-09-29T06:00:16.488Z
Learning: In the express-zod-api repository, the project uses pnpm workspaces with autoInstallPeers: false, meaning peerDependencies are not installed. The actual TypeScript version used for development comes from devDependencies which references "catalog:dev" in pnpm-workspace.yaml where it's set to a recent version (^5.9.2), not the peerDependency version which is just the minimum consumer requirement.

Applied to files:

  • migration/package.json
🔇 Additional comments (1)
migration/package.json (1)

37-39: No issues found—engines field is already consistent across packages.

Verification confirms that the main express-zod-api package already declares the same engines constraint (^20.19.0 || ^22.12.0 || ^24.0.0) as the migration package, along with zod-plugin. The addition of the engines field to migration/package.json is correct and maintains consistency throughout the project.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@RobinTail RobinTail merged commit 1163661 into master Nov 15, 2025
13 checks passed
@RobinTail RobinTail deleted the add-engines-migration branch November 15, 2025 11:37
@coveralls-official
Copy link
Copy Markdown

coveralls-official Bot commented Nov 15, 2025

Coverage Status

coverage: 100.0%. remained the same
when pulling 0d5c37c on add-engines-migration
into 1bce19c on master.

@RobinTail RobinTail mentioned this pull request Nov 22, 2025
Merged
RobinTail added a commit that referenced this pull request Nov 22, 2025
@RobinTail
Rev: Import extensions (#3055)
67da842 
- This reverts #2974  (Not going to go that direction)
- Instead, sets the module `preserve`, target `esnext` and `bundler`
resolutions, to rely on `tsdown` builds
- All targets are configured to the lowest supported Node version by
#3066 and #2912

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Refactor**
* Standardized module import paths across the codebase to improve
compatibility and consistency.
* Updated TypeScript configuration for enhanced module resolution
handling.

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@RobinTail RobinTail mentioned this pull request Nov 29, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

prevention

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@RobinTail