Skip to content

Enabling noUncheckedSideEffectImports globally#2972

Merged
RobinTail merged 1 commit intomasterfrom
strict-noUncheckedSideEffectImports
Sep 28, 2025
Merged

Enabling noUncheckedSideEffectImports globally#2972
RobinTail merged 1 commit intomasterfrom
strict-noUncheckedSideEffectImports

Conversation

@RobinTail
Copy link
Copy Markdown
Owner

@RobinTail RobinTail commented Sep 28, 2025 •
edited by coderabbitai Bot
Loading

This is one of the recommended settings of latest Typescript. It checks if side effect imports do exist and correct.
Since the framework does have side effects via zod-plugin, this setting makes sense to activate.

https://www.typescriptlang.org/tsconfig/#noUncheckedSideEffectImports

Summary by CodeRabbit

  • Chores
    • Maintenance-only update: internal TypeScript compiler configuration adjusted for development/build processes. No changes to functionality, interface, performance, or compatibility. No impact on data, settings, or user workflows. App behavior remains the same across all platforms. No action required.

@RobinTail RobinTail marked this pull request as ready for review September 28, 2025 09:28
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Sep 28, 2025 •
edited
Loading

Walkthrough

Updated tsconfig.json to enable the TypeScript compiler option noUncheckedSideEffectImports: true, aligning it with existing strict options.

Changes

Cohort / File(s) Summary of Changes
TypeScript compiler settings
tsconfig.json		 Added "noUncheckedSideEffectImports": true to compilerOptions alongside other strict settings.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I twitch my ears at stricter sights,
Imports checked in TypeScript nights.
No sneaky side-effects to slip—
I nibble bugs with gentle grip.
With tidy stacks and burrowed lore,
Our code hops safer than before. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly and accurately reflects the primary change in the pull request by stating that the noUncheckedSideEffectImports compiler option is being enabled globally, which aligns directly with the modification to tsconfig.json described in the PR.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch strict-noUncheckedSideEffectImports

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@RobinTail RobinTail merged commit 78de8a7 into master Sep 28, 2025
13 checks passed
@RobinTail RobinTail deleted the strict-noUncheckedSideEffectImports branch September 28, 2025 09:35
@coderabbitai coderabbitai Bot mentioned this pull request Nov 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CI/CD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@RobinTail