Skip to content

Making EndpointsFactory::#create() an instance method#2776

Merged
RobinTail merged 2 commits intomasterfrom
nonstatic-factory-create
Jun 29, 2025
Merged

Making EndpointsFactory::#create() an instance method#2776
RobinTail merged 2 commits intomasterfrom
nonstatic-factory-create

Conversation

@RobinTail
Copy link
Copy Markdown
Owner

@RobinTail RobinTail commented Jun 29, 2025 •
edited by coderabbitai Bot
Loading

I think it's a legacy that it used to be static.
It could be simplified now.

I'd like to reuse it for #2777

Summary by CodeRabbit

Summary by CodeRabbit

  • Refactor
    • Improved internal logic for endpoint factory creation to enhance maintainability. No changes to user-facing features or behavior.

@RobinTail RobinTail added the refactoring The better way to achieve the same result label Jun 29, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 29, 2025 •
edited
Loading

Walkthrough

The EndpointsFactory class was updated by converting its private #create method from a static to an instance method. All internal invocations of #create now use the instance context and no longer require the resultHandler parameter, instead accessing it from the instance property.

Changes

File Change Summary
express-zod-api/src/endpoints-factory.ts Refactored EndpointsFactory.#create from static to instance method; updated all related calls

Poem

A factory hops with methods anew,
No more static calls, just "this" will do!
The handler’s now close, within easy reach,
As rabbits refactor, and code they teach.
Instance-bound magic, in burrows so deep,
The endpoints are tidy, the logic is neat!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d27406f and 016bfbe.

📒 Files selected for processing (1)
  • express-zod-api/src/endpoints-factory.ts (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • express-zod-api/src/endpoints-factory.ts
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@RobinTail RobinTail marked this pull request as ready for review June 29, 2025 13:50
@RobinTail RobinTail changed the title Making private EndpointsFactory::create() non-static Making EndpointsFactory::create() an instance method Jun 29, 2025
@RobinTail RobinTail changed the title Making EndpointsFactory::create() an instance method Making EndpointsFactory::#create() an instance method Jun 29, 2025
RobinTail
RobinTail commented Jun 29, 2025
View reviewed changes
Copy link
Copy Markdown
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@RobinTail RobinTail merged commit 90e1b15 into master Jun 29, 2025
13 checks passed
@RobinTail RobinTail deleted the nonstatic-factory-create branch June 29, 2025 14:02
@coderabbitai coderabbitai Bot mentioned this pull request Jun 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

refactoring The better way to achieve the same result

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@RobinTail