Skip to content

Using R.renameKeys() for zod-plugin's method remap()#2775

Merged
RobinTail merged 3 commits intomasterfrom
use-ramda-renameKeys-for-remap
Jun 29, 2025
Merged

Using R.renameKeys() for zod-plugin's method remap()#2775
RobinTail merged 3 commits intomasterfrom
use-ramda-renameKeys-for-remap

Conversation

@RobinTail
Copy link
Copy Markdown
Owner

@RobinTail RobinTail commented Jun 29, 2025 •
edited by coderabbitai Bot
Loading

The new method introduced in Ramda 0.31, see #2764
For the edge case of undefined value in tooling it behaves a little different, so I'm addressing it using R.reject(R.isNil()).
The official typing is not yet ready, so I'm using augmentation until it's done.

Summary by CodeRabbit

  • Refactor
    • Simplified key remapping logic for object transformation, improving reliability and maintainability.
  • Chores
    • Enhanced type safety by adding TypeScript type declarations for external library functions.

@RobinTail RobinTail added the refactoring The better way to achieve the same result label Jun 29, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 29, 2025 •
edited
Loading

Walkthrough

The update introduces a TypeScript module declaration for the Ramda library, specifically typing the renameKeys function. Additionally, the objectMapper logic in the ZodObject extension is refactored to use R.renameKeys directly with filtered mappings, simplifying the key remapping process and enhancing type safety.

Changes

File(s) Change Summary
express-zod-api/src/zod-plugin.ts Added TypeScript module declaration for Ramda's renameKeys and refactored objectMapper logic
CHANGELOG.md Added patch version v24.4.3 noting delegation of z.object().remap() to R.renameKeys()

Suggested labels

dependencies

Poem

In the land of keys, where mappings play,
A rabbit hops and clears the way.
With typings neat and logic bright,
RenameKeys now works just right!
Type safety blooms, the code feels light—
A bunny’s joy in every byte. 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2807ae1 and af05eff.

📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: build (24.x)
  • GitHub Check: build (24.0.0)
  • GitHub Check: build (22.x)
  • GitHub Check: build (20.9.0)
  • GitHub Check: build (20.x)
  • GitHub Check: build (22.0.0)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@RobinTail RobinTail marked this pull request as ready for review June 29, 2025 08:08
@coveralls-official
Copy link
Copy Markdown

coveralls-official Bot commented Jun 29, 2025 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling af05eff on use-ramda-renameKeys-for-remap
into af8015b on master.

RobinTail
RobinTail commented Jun 29, 2025
View reviewed changes
Copy link
Copy Markdown
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@RobinTail RobinTail merged commit f6a9669 into master Jun 29, 2025
13 checks passed
@RobinTail RobinTail deleted the use-ramda-renameKeys-for-remap branch June 29, 2025 09:21
This was referenced Jul 29, 2025
Merged
Closed
@coderabbitai coderabbitai Bot mentioned this pull request Aug 8, 2025
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Oct 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

refactoring The better way to achieve the same result

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@RobinTail