Conversation
RobinTail
added
dependencies
This reverts commit 117b1fa.
Owner
Author
|
looks like provenance is lost in beta.3 |
RobinTail
force-pushed
the
try-pnpm-again
branch
from
d2e3457 to
c17ebec
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
168-168: Consider link readability and permanence.Replacing the full URL with a TinyURL may obscure the destination and risks link rot if the redirect service changes. Prefer using the original URL or a project-controlled redirect for clarity and longevity.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: build (20.x)
- GitHub Check: build (22.0.0)
- GitHub Check: build (24.x)
- GitHub Check: build (24.0.0)
- GitHub Check: build (20.9.0)
- GitHub Check: build (22.x)
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
README.md (1)
171-173: Approve updated pnpm installation commands.The pnpm add commands correctly reflect the migration from Yarn to pnpm and are consistent with the PR objectives.
This was referenced Jun 11, 2025
Merged
RobinTail
added a commit
that referenced
this pull request
Jun 15, 2025
Addition to #2428 It turned out that required peer dependencies are installed automatically unless opted out: https://pnpm.io/next/settings#autoinstallpeers This might be a better solution since I want to absorb the validation workflow into the existing integration tests without hoisting Discovered while working on #2736 and might be needed to solve in advance <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated dependencies across multiple packages to use a centralized peer dependency catalog. - Added a new peer dependency catalog to the workspace configuration, listing key runtime and type definition packages. - Adjusted package dependencies to reference the new peer catalog, removing direct versioned dependencies where applicable. - Added or updated peer dependencies for packages such as zod and http-errors in relevant projects. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This was referenced Jul 19, 2025
This was referenced Jul 29, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see the need to migrate from
yarnclassic (despite my sincere love of it) because I noticed warnings in Node 24 environment about the deprecated methods used byyarn, that are (most likely) not going to be fixed, so thatyarnclassic would probably become non-operational in Node 25/26 (in a year).Reiterating #2067
Based on the findings of #2427
And using the advantage of having workspaces introduced in #2374
attwissue in workspacepnpm packdoes not work in workspacepnpm pack --filterpnpm/pnpm#4351working-directoryin CIpnpm versiondoes not work in workspace, but there is a workaround Implement npm-version with pnpm workspace support pnpm/pnpm#8064npmbug: [BUG] npm-version does not git-commit nor git-tag when package in subdirectory npm/cli#2010yarn@v4that I tried recentlySummary by CodeRabbit
Summary by CodeRabbit
Chores
Bug Fixes
Refactor
Style