Conversation
RobinTail
commented
Feb 7, 2025
ac0e57d to
1c660e9
Compare
57ddead to
442a264
Compare
Owner
Author
|
Hooley sheet! |
RobinTail
commented
Feb 7, 2025
RobinTail
commented
Feb 7, 2025
RobinTail
commented
Feb 8, 2025
RobinTail
commented
Feb 8, 2025
Owner
Author
RobinTail
left a comment
There was a problem hiding this comment.
looking good.
need to review manifests and lock file once again
RobinTail
commented
Feb 8, 2025
RobinTail
commented
Feb 8, 2025
RobinTail
commented
Feb 8, 2025
RobinTail
commented
Feb 8, 2025
Owner
Author
RobinTail
left a comment
There was a problem hiding this comment.
OK
upgrades should be conducted using the following command:
yarn workspace express-zod-api upgrade
Owner
Author
Owner
Author
|
✅ QA passed |
This was referenced Feb 21, 2025
Closed
Merged
Closed
RobinTail
added a commit
that referenced
this pull request
Jun 11, 2025
I see the need to migrate from `yarn` classic (despite my sincere love of it) because I noticed warnings in Node 24 environment about the deprecated methods used by `yarn`, that are (most likely) not going to be fixed, so that `yarn` classic would probably become non-operational in Node 25/26 (in a year). Reiterating #2067 Based on the findings of #2427 And using the advantage of having workspaces introduced in #2374 - it fixes `attw` issue in workspace - `pnpm pack` does not work in workspace - pnpm/pnpm#4351 - using `working-directory` in CI - `pnpm version` does not work in workspace, but there is a workaround pnpm/pnpm#8064 - but it does not work due to another `npm` bug: npm/cli#2010 - possible solution https://www.npmjs.com/package/bumpp - but overall clarity and consistency is much better than even `yarn@v4` that I tried recently <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **Chores** - Migrated project tooling and workflows from Yarn to pnpm for package management. - Updated all CI workflows and pre-commit hooks to use pnpm commands. - Adjusted documentation and contributing guidelines to reflect pnpm usage. - Introduced a pnpm workspace configuration and updated ignore files accordingly. - Updated package.json scripts and resolutions to align with pnpm usage. - Added explicit workspace dependencies in test and example projects for improved clarity and reliability. - **Bug Fixes** - Improved TypeScript compatibility with a workaround for a specific type error. - **Refactor** - Simplified internal scripts and utility logic by removing Ramda dependencies and adopting native JavaScript approaches. - **Style** - Updated package scripts and configuration files for consistency with pnpm standards. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reiteration of #1351 having improved dependencies and environment