Skip to content

Ref: Workspaces#2374

Merged
RobinTail merged 60 commits intomasterfrom
again-workspaces
Feb 8, 2025
Merged

Ref: Workspaces#2374
RobinTail merged 60 commits intomasterfrom
again-workspaces

Conversation

@RobinTail
Copy link
Copy Markdown
Owner

Reiteration of #1351 having improved dependencies and environment

@RobinTail RobinTail added refactoring The better way to achieve the same result CI/CD labels Feb 7, 2025
Comment thread example/index.spec.ts
@RobinTail RobinTail added coverage Additional tests miracle Mysterious events are happening here labels Feb 7, 2025
@RobinTail
Copy link
Copy Markdown
Owner Author

Hooley sheet!
it worked out this time

@RobinTail RobinTail changed the title Exp: workspaces Ref: orkspaces Feb 7, 2025
@RobinTail RobinTail changed the title Ref: orkspaces Ref: Workspaces Feb 7, 2025
@coveralls-official
Copy link
Copy Markdown

coveralls-official Bot commented Feb 7, 2025

Coverage Status

coverage: 100.0%. remained the same
when pulling 97d032b on again-workspaces
into d848cd4 on master.

Comment thread express-zod-api/logo.svg
Comment thread esm-test/quick-start.spec.ts Outdated
Comment thread .github/workflows/beta.yml Outdated
Copy link
Copy Markdown
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good.
need to review manifests and lock file once again

Comment thread express-zod-api/package.json Outdated
Comment thread express-zod-api/package.json Outdated
Comment thread package.json Outdated
Copy link
Copy Markdown
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

upgrades should be conducted using the following command:

yarn workspace express-zod-api upgrade

@RobinTail
Copy link
Copy Markdown
Owner Author

@RobinTail
Copy link
Copy Markdown
Owner Author

✅ QA passed

@RobinTail RobinTail added the documentation Improvements or additions to documentation label Feb 8, 2025
Copy link
Copy Markdown
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready

@RobinTail RobinTail merged commit e6faaf8 into master Feb 8, 2025
@RobinTail RobinTail deleted the again-workspaces branch February 8, 2025 16:49
This was referenced Feb 21, 2025
RobinTail added a commit that referenced this pull request Jun 11, 2025
I see the need to migrate from `yarn` classic (despite my sincere love
of it) because I noticed warnings in Node 24 environment about the
deprecated methods used by `yarn`, that are (most likely) not going to
be fixed, so that `yarn` classic would probably become non-operational
in Node 25/26 (in a year).

Reiterating #2067 
Based on the findings of #2427 
And using the advantage of having workspaces introduced in #2374 

- it fixes `attw` issue in workspace
- `pnpm pack` does not work in workspace
  - pnpm/pnpm#4351
  - using `working-directory` in CI
- `pnpm version` does not work in workspace, but there is a workaround
pnpm/pnpm#8064
- but it does not work due to another `npm` bug:
npm/cli#2010
  - possible solution https://www.npmjs.com/package/bumpp
- but overall clarity and consistency is much better than even `yarn@v4`
that I tried recently

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **Chores**
- Migrated project tooling and workflows from Yarn to pnpm for package
management.
  - Updated all CI workflows and pre-commit hooks to use pnpm commands.
- Adjusted documentation and contributing guidelines to reflect pnpm
usage.
- Introduced a pnpm workspace configuration and updated ignore files
accordingly.
- Updated package.json scripts and resolutions to align with pnpm usage.
- Added explicit workspace dependencies in test and example projects for
improved clarity and reliability.

- **Bug Fixes**
- Improved TypeScript compatibility with a workaround for a specific
type error.

- **Refactor**
- Simplified internal scripts and utility logic by removing Ramda
dependencies and adopting native JavaScript approaches.

- **Style**
- Updated package scripts and configuration files for consistency with
pnpm standards.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD coverage Additional tests documentation Improvements or additions to documentation miracle Mysterious events are happening here refactoring The better way to achieve the same result

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant