Replacing form-data with native FormData of Node 18#1644
Merged
Conversation
RobinTail
added
dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for #1617
Related to form-data/form-data#558
Using the native Node 18+ FormData (using it in tests).
It turned out that in version 18.0.0 (only),
FormData::setand::append()do not take the MIME type of theBlobinto account, and it's an empty string, which always lead toapplication/octet-streaminstead of actual MIME type.Blob::typeis readonly via getter-only approach, so there is no way to hack it.So I disabled the MIME type check for Node 18.0.0 test.