Skip to content

Experiment: workspaces#1351

Closed
RobinTail wants to merge 50 commits intomasterfrom
try-workspaces
Closed

Experiment: workspaces#1351
RobinTail wants to merge 50 commits intomasterfrom
try-workspaces

Conversation

@RobinTail
Copy link
Copy Markdown
Owner

The environment became complex enough to consider such approach.
It may help to organize different sections accordingly.
Besides that, example can refer to the distribution name instead of sources.

https://classic.yarnpkg.com/lang/en/docs/workspaces/
https://docs.npmjs.com/cli/v10/using-npm/workspaces

@RobinTail RobinTail added refactoring The better way to achieve the same result CI/CD labels Dec 3, 2023
@RobinTail
Copy link
Copy Markdown
Owner Author

class Intergration and Documentation tests do actually refer to example workspace, which by referring to "express-zod-api" workspace, makes a broken loop also leading to testing dist instead of sources.
Perhaps such tests should be moved to example workspace, however, it's not clear if all that even make the environment easier to operate.

@RobinTail
Copy link
Copy Markdown
Owner Author

Got it. I just need to remove example referring tests from the tests of those two classes, or split.

@RobinTail
Copy link
Copy Markdown
Owner Author

RobinTail commented Dec 3, 2023

Current issue is eslint import rule that has to be fixed for monrepo
✅ fixed

Comment thread example/example.swagger.yaml Outdated
Comment thread tools/license.ts
@RobinTail
Copy link
Copy Markdown
Owner Author

Symlink for Readme kinda work on the root — GitHub can render the content.
However, the disadvantage of it is a confusion with relative links, to changelog for example.
Better to find another solution.

@RobinTail
Copy link
Copy Markdown
Owner Author

The problem with those workspaces is that somehow @tsd/typescript interferes with the globals of regular typescript, even in workspaces that do not use tsd. Despite the advantage of sharing dependencies between the workspaces, it all mixes up and pollutes the globals everywhere, affecting the development experience by messing up the types, including jest and vitest globals too.
I could not find a pretty solution for that problem yet.

RobinTail added a commit that referenced this pull request Dec 5, 2023
@RobinTail RobinTail added the wontfix This will not be worked on label Dec 5, 2023
RobinTail added a commit that referenced this pull request Dec 5, 2023
Instead of #1351 I'm going to remove redundant things I found during
working on that and simplify my environment based on my corresponding
findings.
Comment thread tsconfig.json
RobinTail added a commit that referenced this pull request Dec 5, 2023
RobinTail added a commit that referenced this pull request Dec 5, 2023
@RobinTail
Copy link
Copy Markdown
Owner Author

I made improvements to my current environment instead based on the findings of this work

@RobinTail RobinTail closed this Dec 5, 2023
@RobinTail RobinTail mentioned this pull request Feb 7, 2025
RobinTail added a commit that referenced this pull request Feb 8, 2025
Reiteration of #1351 having improved dependencies and environment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD refactoring The better way to achieve the same result wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant