Ref: flipping condition in pipeline overrider and producer.

RobinTail · RobinTail · commit 9e66ffd8d8b6 · 2025-04-25T23:31:53.000+02:00
diff --git a/express-zod-api/src/documentation-helpers.ts b/express-zod-api/src/documentation-helpers.ts
@@ -271,28 +271,24 @@ export const onPipeline: Overrider = ({ zodSchema, jsonSchema }, ctx) => {
   const opposite = (zodSchema as $ZodPipe)._zod.def[
     ctx.isResponse ? "in" : "out"
   ];
-  if (isSchema<$ZodTransform>(target, "transform")) {
-    const opposingDepiction = depict(opposite, { ctx });
-    if (isSchemaObject(opposingDepiction)) {
-      if (!ctx.isResponse) {
-        const { type: opposingType, ...rest } = opposingDepiction;
+  if (!isSchema<$ZodTransform>(target, "transform")) return;
+  const opposingDepiction = depict(opposite, { ctx });
+  if (isSchemaObject(opposingDepiction)) {
+    if (!ctx.isResponse) {
+      const { type: opposingType, ...rest } = opposingDepiction;
+      Object.assign(jsonSchema, {
+        ...rest,
+        format: `${rest.format || opposingType} (preprocessed)`,
+      });
+    } else {
+      const targetType = getTransformedType(
+        target,
+        makeSample(opposingDepiction),
+      );
+      if (targetType && ["number", "string", "boolean"].includes(targetType)) {
         Object.assign(jsonSchema, {
-          ...rest,
-          format: `${rest.format || opposingType} (preprocessed)`,
+          type: targetType as "number" | "string" | "boolean",
         });
-      } else {
-        const targetType = getTransformedType(
-          target,
-          makeSample(opposingDepiction),
-        );
-        if (
-          targetType &&
-          ["number", "string", "boolean"].includes(targetType)
-        ) {
-          Object.assign(jsonSchema, {
-            type: targetType as "number" | "string" | "boolean",
-          });
-        }
       }
     }
   }
diff --git a/express-zod-api/src/zts.ts b/express-zod-api/src/zts.ts
@@ -184,24 +184,22 @@ const onPipeline: Producer = (
 ) => {
   const target = def[isResponse ? "out" : "in"];
   const opposite = def[isResponse ? "in" : "out"];
-  if (isSchema<$ZodTransform>(target, "transform")) {
-    const opposingType = next(opposite);
-    const targetType = getTransformedType(target, makeSample(opposingType));
-    const resolutions: Partial<
-      Record<NonNullable<typeof targetType>, ts.KeywordTypeSyntaxKind>
-    > = {
-      number: ts.SyntaxKind.NumberKeyword,
-      bigint: ts.SyntaxKind.BigIntKeyword,
-      boolean: ts.SyntaxKind.BooleanKeyword,
-      string: ts.SyntaxKind.StringKeyword,
-      undefined: ts.SyntaxKind.UndefinedKeyword,
-      object: ts.SyntaxKind.ObjectKeyword,
-    };
-    return ensureTypeNode(
-      (targetType && resolutions[targetType]) || ts.SyntaxKind.AnyKeyword,
-    );
-  }
-  return next(target);
+  if (!isSchema<$ZodTransform>(target, "transform")) return next(target);
+  const opposingType = next(opposite);
+  const targetType = getTransformedType(target, makeSample(opposingType));
+  const resolutions: Partial<
+    Record<NonNullable<typeof targetType>, ts.KeywordTypeSyntaxKind>
+  > = {
+    number: ts.SyntaxKind.NumberKeyword,
+    bigint: ts.SyntaxKind.BigIntKeyword,
+    boolean: ts.SyntaxKind.BooleanKeyword,
+    string: ts.SyntaxKind.StringKeyword,
+    undefined: ts.SyntaxKind.UndefinedKeyword,
+    object: ts.SyntaxKind.ObjectKeyword,
+  };
+  return ensureTypeNode(
+    (targetType && resolutions[targetType]) || ts.SyntaxKind.AnyKeyword,
+  );
 };
 
 const onNull: Producer = () => makeLiteralType(null);
