Skip to content

Commit 83dfadd

Browse files
committed
a couple todos.
1 parent 4988336 commit 83dfadd

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

express-zod-api/src/documentation-helpers.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -429,6 +429,7 @@ const overrides: Partial<Record<FirstPartyKind | ProprietaryBrand, Overrider>> =
429429

430430
const onEach: Overrider = ({ zodSchema, jsonSchema }, { isResponse }) => {
431431
const { description, deprecated } = globalRegistry.get(zodSchema) ?? {};
432+
// @todo check if this still required after updating the core
432433
if (description) jsonSchema.description ??= description;
433434
if (deprecated) jsonSchema.deprecated = true;
434435
const shouldAvoidParsing =
@@ -485,7 +486,7 @@ const depict = (
485486
z.object({ subject }), // avoiding "document root" references
486487
{
487488
unrepresentable: "any",
488-
metadata: globalRegistry,
489+
metadata: globalRegistry, // @todo might be redundant
489490
io: ctx.isResponse ? "output" : "input",
490491
override: (zodCtx) => {
491492
const { brand } =

0 commit comments

Comments
 (0)