ensureError: convert ZodError to ZodRealError.

RobinTail · RobinTail · commit 834fe45753b2 · 2025-05-23T10:10:22.000+02:00
diff --git a/express-zod-api/src/common-helpers.ts b/express-zod-api/src/common-helpers.ts
@@ -66,12 +66,7 @@ export const ensureError = (subject: unknown): Error =>
   subject instanceof Error
     ? subject
     : subject instanceof z.ZodError
-      ? /**
-         * its message is a serialization of issues, so that I'm making it readable here
-         * @todo rm if fixed:
-         * @link https://github.com/colinhacks/zod/pull/4436/
-         * */
-        new Error(getMessageFromError(subject), { cause: subject })
+      ? new z.ZodRealError(subject.issues) // ZodError is not an instance of Error, unlike ZodRealError that is
       : new Error(String(subject));
 
 export const getMessageFromError = (error: Error): string => {
diff --git a/express-zod-api/tests/common-helpers.spec.ts b/express-zod-api/tests/common-helpers.spec.ts
@@ -225,7 +225,15 @@ describe("Common Helpers", () => {
             message: "invalid type",
           },
         ]),
-        "invalid type",
+        "[\n" +
+          "  {\n" +
+          '    "code": "invalid_type",\n' +
+          '    "expected": "string",\n' +
+          '    "input": 123,\n' +
+          '    "path": [],\n' +
+          '    "message": "invalid type"\n' +
+          "  }\n" +
+          "]",
       ],
       [createHttpError(500, "Internal Server Error"), "Internal Server Error"],
       [undefined, "undefined"],
diff --git a/express-zod-api/tests/env.spec.ts b/express-zod-api/tests/env.spec.ts
@@ -61,6 +61,23 @@ describe("Environment checks", () => {
         Object.getOwnPropertyDescriptors(schema._zod.def.shape),
       ).toMatchSnapshot();
     });
+
+    test("ZodError inequality", () => {
+      const issue: z.core.$ZodIssue = {
+        code: "invalid_type",
+        expected: "string",
+        input: 123,
+        path: [],
+        message: "expected string, received number",
+      };
+      const error = new z.ZodError([issue]);
+      const real = new z.ZodRealError([issue]);
+      expect(error).not.toBeInstanceOf(Error); // and this is important
+      expect(real).toBeInstanceOf(Error);
+      expect(real).toBeInstanceOf(z.ZodError); // important inheritance
+      expect(error).toHaveProperty("message");
+      expect(real).toHaveProperty("message");
+    });
   });
 
   describe("Zod new features", () => {
