Improve handling of ZodError by ensureError.

RobinTail · RobinTail · commit 287b126f34c1 · 2025-04-23T20:56:23.000+02:00
diff --git a/express-zod-api/src/common-helpers.ts b/express-zod-api/src/common-helpers.ts
@@ -67,7 +67,7 @@ export const ensureError = (subject: unknown): Error =>
   subject instanceof Error
     ? subject
     : subject instanceof z.ZodError
-      ? new Error(subject.message)
+      ? new Error(getMessageFromError(subject), { cause: subject })
       : new Error(String(subject));
 
 export const getMessageFromError = (error: Error): string => {
diff --git a/express-zod-api/tests/__snapshots__/system.spec.ts.snap b/express-zod-api/tests/__snapshots__/system.spec.ts.snap
@@ -122,24 +122,17 @@ exports[`App in production mode > Validation > Problem 787: Should NOT treat Zod
   "Server side error",
   {
     "error": InternalServerError({
-      "cause": Error({
-        "message": "[
-  {
-    "expected": "number",
-    "code": "invalid_type",
-    "path": [],
-    "message": "Invalid input: expected number, received string"
-  }
-]",
-      }),
-      "message": "[
-  {
-    "expected": "number",
-    "code": "invalid_type",
-    "path": [],
-    "message": "Invalid input: expected number, received string"
-  }
-]",
+      "cause": ZodError {
+        "issues": [
+          {
+            "code": "invalid_type",
+            "expected": "number",
+            "message": "Invalid input: expected number, received string",
+            "path": [],
+          },
+        ],
+      },
+      "message": "Invalid input: expected number, received string",
     }),
     "payload": {
       "key": "123",
diff --git a/express-zod-api/tests/common-helpers.spec.ts b/express-zod-api/tests/common-helpers.spec.ts
@@ -349,13 +349,11 @@ describe("Common Helpers", () => {
             code: "invalid_type",
             expected: "string",
             input: 123,
-            path: [""],
+            path: [],
             message: "invalid type",
           },
         ]),
-        `[\n  {\n    "code": "invalid_type",\n    "expected": "string",\n` +
-          `    "input": 123,\n    "path": [\n      ""\n` +
-          `    ],\n    "message": "invalid type"\n  }\n]`,
+        "invalid type",
       ],
       [createHttpError(500, "Internal Server Error"), "Internal Server Error"],
       [undefined, "undefined"],
