Fix EromeRipper doesn't correctly download albums that are a mix of images and video (Fixes #2121)#2141
Merged
soloturn merged 1 commit intoRipMeApp:mainfrom Aug 7, 2025
Conversation
metaprime
reviewed
Sep 20, 2025
| @Tag("slow") | ||
| public void testVideoAlbumRip() throws IOException, URISyntaxException { | ||
| URL url = new URI("https://www.erome.com/a/P0x5Ambn").toURL(); | ||
| URL url = new URI("https://www.erome.com/a/jEUFu6pi").toURL(); |
Contributor
There was a problem hiding this comment.
The old URL seems to be valid as well, but the new one is an album containing 2 videos which seems like a better test (and more SFW which is good).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
This change is exactly one of the following (please change
[ ]to[x]) to indicate which:Description
Fixed EromeRipper to correctly download video URLs by using
this.url.toString()instead of hardcoded "erome.com". Also changed test to use a working video album link.Testing
Required verification:
gradlew test(there are no new failures or errors).Optional but recommended: