Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes MrCongRipper to use the new URL domain misskon.com (Fixes #2127) by updating domain references and related URL processing.
- Updated host and domain references from mrcong.com to misskon.com in both main and test files.
- Modified regex patterns and exception messages to match the new URL format.
- Changed image source attribute extraction from "src" to "data-src" to support lazy-loaded images.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/test/java/com/rarchives/ripme/tst/ripper/rippers/MrCongRipperTest.java | Updated tests to reference misskon.com URLs. |
| src/main/java/com/rarchives/ripme/ripper/rippers/MrCongRipper.java | Adjusted domain, regex patterns, and image attribute extraction for new URL behaviors. |
src/main/java/com/rarchives/ripme/ripper/rippers/MrCongRipper.java
Outdated
Show resolved
Hide resolved
…java Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
This change is exactly one of the following (please change
[ ]to[x]) to indicate which:Description
This ripper was previously for mrcong.com, which now redirects to
misskon.com. Some resources still refer to mrcong.com
but all the top level URLs are now misskon.com
Testing
Required verification:
gradlew test(there are no new failures or errors).Optional but recommended: