Update HentaiimageRipper for new URL (Fixes #2122)#2123
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #2122 by updating the URL handling in HentaiimageRipper to reflect the new domain.
- Updated the test URL in HentaiimageRipperTest to the new domain.
- Modified the regex in HentaiimageRipper to accept the new URL format.
- Adjusted the error message to correspond to the updated URL.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/test/java/com/rarchives/ripme/tst/ripper/rippers/HentaiimageRipperTest.java | Updated the test URL to use the new domain. |
| src/main/java/com/rarchives/ripme/ripper/rippers/HentaiimageRipper.java | Adjusted the regex and error message for the updated URL format. |
Comments suppressed due to low confidence (1)
src/main/java/com/rarchives/ripme/ripper/rippers/HentaiimageRipper.java:50
- [nitpick] Consider updating the error message to accurately describe the expected URL format for HentaiimageRipper instead of referencing 'hitomi URL format', to avoid potential confusion.
"https://hentai-img-xxx.com/image/ID - got " + url + " instead"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
This change is exactly one of the following (please change
[ ]to[x]) to indicate which:Description
The URL changed. Updated the ripper and test.
Testing
Required verification:
gradlew test(there are no new failures or errors).Optional but recommended: