Update CfakeRipper to new site format (Fixes #2116)#2117
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CfakeRipper to adapt to the site's new URL format and layout. Key changes include:
- Updating the regex pattern to match the new URL format.
- Modifying element selection in getNextPage to reflect the redesigned page layout.
- Adjusting image URL transformation in getURLsFromPage to use HTTPS and convert thumbnails to full-size photos.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/test/java/com/rarchives/ripme/tst/ripper/rippers/CfakeRipperTest.java | Updated test URL to match the new site format. |
| src/main/java/com/rarchives/ripme/ripper/rippers/CfakeRipper.java | Revised regex, page navigation, and image URL handling logic. |
Comments suppressed due to low confidence (1)
src/main/java/com/rarchives/ripme/ripper/rippers/CfakeRipper.java:52
- The comment still references 'comic-nav-next' which is inconsistent with the updated element selection logic. Please update the comment to accurately describe the new navigation strategy.
// We use comic-nav-next to the find the next page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
This change is exactly one of the following (please change
[ ]to[x]) to indicate which:Description
Cfake site changed URL and layout. This PR fixes the ripper to align with the new site layout.
Testing
Required verification:
gradlew test(there are no new failures or errors).Optional but recommended: