Add a ScrollView to hold the list of supported sites in the About dialog (Fixes #2104)#2114
Merged
Add a ScrollView to hold the list of supported sites in the About dialog (Fixes #2104)#2114
Conversation
Contributor
Author
|
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with the About dialog by embedding the long list of supported sites into a scrollable view, avoiding an overly tall dialog.
- Replaces the static HTML content with a JTextArea populated from album and video rippers.
- Introduces a JScrollPane with a fixed preferred size and ensures it scrolls to the top on display.
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
This change is exactly one of the following (please change
[ ]to[x]) to indicate which:Description
The "about" dialog accessible from the system tray icon had too much content without a scrollview that made the dialog too tall. This changes it so that the long list of sites supported is inside of a scrollview.
Testing
Required verification:
gradlew test(there are no new failures or errors).Optional but recommended: