Repository navigation
Commit 01f1c92
committed
fix: exhaustive destructuring in proto hooks for sort_expr, partitioning, and repartition
Add `let Self { .. }` (encoder) and prost-node destructuring (decoder) to
`PhysicalSortExpr`, `Partitioning`, and `RangeExpr` proto hooks so that
adding a field to any of these types is a compile error in both directions
rather than a silently-dropped round-trip gap. Follows the convention
established by apache#24164 for the join-plan hooks.
Also adds round-trip tests for `Partitioning::Range` and `RangeExpr`,
the two hooks that had no existing colocated proto test.
Closes apache#246191 parent 5e42247 commit 01f1c92
3 files changed
Lines changed: 181 additions & 36 deletions
File tree
- datafusion
- physical-expr-common/src
- physical-expr/src
- physical-plan/src/repartition
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
199 | 199 | | |
200 | 200 | | |
201 | 201 | | |
| 202 | + | |
202 | 203 | | |
203 | | - | |
204 | | - | |
205 | | - | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
206 | 207 | | |
207 | 208 | | |
208 | 209 | | |
| |||
211 | 212 | | |
212 | 213 | | |
213 | 214 | | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | | - | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
219 | 222 | | |
220 | 223 | | |
221 | 224 | | |
222 | | - | |
223 | | - | |
| 225 | + | |
| 226 | + | |
224 | 227 | | |
225 | 228 | | |
226 | 229 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
629 | 629 | | |
630 | 630 | | |
631 | 631 | | |
632 | | - | |
633 | | - | |
634 | | - | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
635 | 638 | | |
636 | 639 | | |
637 | 640 | | |
| |||
673 | 676 | | |
674 | 677 | | |
675 | 678 | | |
676 | | - | |
| 679 | + | |
| 680 | + | |
677 | 681 | | |
678 | 682 | | |
679 | 683 | | |
680 | 684 | | |
681 | 685 | | |
682 | 686 | | |
683 | 687 | | |
684 | | - | |
685 | | - | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
686 | 693 | | |
687 | 694 | | |
688 | 695 | | |
689 | | - | |
| 696 | + | |
690 | 697 | | |
691 | 698 | | |
692 | 699 | | |
693 | 700 | | |
694 | 701 | | |
695 | | - | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
696 | 707 | | |
697 | 708 | | |
698 | 709 | | |
| |||
704 | 715 | | |
705 | 716 | | |
706 | 717 | | |
707 | | - | |
708 | | - | |
| 718 | + | |
709 | 719 | | |
710 | 720 | | |
711 | 721 | | |
| |||
1575 | 1585 | | |
1576 | 1586 | | |
1577 | 1587 | | |
| 1588 | + | |
1578 | 1589 | | |
| 1590 | + | |
1579 | 1591 | | |
1580 | 1592 | | |
1581 | 1593 | | |
| 1594 | + | |
1582 | 1595 | | |
1583 | 1596 | | |
1584 | | - | |
| 1597 | + | |
1585 | 1598 | | |
1586 | 1599 | | |
1587 | 1600 | | |
| |||
1662 | 1675 | | |
1663 | 1676 | | |
1664 | 1677 | | |
| 1678 | + | |
| 1679 | + | |
| 1680 | + | |
| 1681 | + | |
| 1682 | + | |
| 1683 | + | |
| 1684 | + | |
| 1685 | + | |
| 1686 | + | |
| 1687 | + | |
| 1688 | + | |
| 1689 | + | |
| 1690 | + | |
| 1691 | + | |
| 1692 | + | |
| 1693 | + | |
| 1694 | + | |
| 1695 | + | |
| 1696 | + | |
| 1697 | + | |
| 1698 | + | |
| 1699 | + | |
| 1700 | + | |
| 1701 | + | |
| 1702 | + | |
| 1703 | + | |
| 1704 | + | |
| 1705 | + | |
| 1706 | + | |
| 1707 | + | |
| 1708 | + | |
| 1709 | + | |
| 1710 | + | |
| 1711 | + | |
| 1712 | + | |
| 1713 | + | |
| 1714 | + | |
| 1715 | + | |
| 1716 | + | |
| 1717 | + | |
| 1718 | + | |
| 1719 | + | |
| 1720 | + | |
| 1721 | + | |
| 1722 | + | |
| 1723 | + | |
| 1724 | + | |
| 1725 | + | |
| 1726 | + | |
| 1727 | + | |
1665 | 1728 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
848 | 848 | | |
849 | 849 | | |
850 | 850 | | |
| 851 | + | |
851 | 852 | | |
852 | 853 | | |
853 | | - | |
854 | | - | |
| 854 | + | |
855 | 855 | | |
856 | | - | |
| 856 | + | |
857 | 857 | | |
858 | 858 | | |
859 | 859 | | |
860 | | - | |
861 | | - | |
| 860 | + | |
862 | 861 | | |
863 | 862 | | |
864 | 863 | | |
| |||
889 | 888 | | |
890 | 889 | | |
891 | 890 | | |
| 891 | + | |
| 892 | + | |
| 893 | + | |
| 894 | + | |
892 | 895 | | |
893 | 896 | | |
894 | | - | |
| 897 | + | |
895 | 898 | | |
896 | 899 | | |
897 | 900 | | |
898 | | - | |
| 901 | + | |
| 902 | + | |
| 903 | + | |
| 904 | + | |
| 905 | + | |
899 | 906 | | |
900 | 907 | | |
901 | 908 | | |
902 | 909 | | |
903 | 910 | | |
904 | | - | |
905 | | - | |
| 911 | + | |
906 | 912 | | |
907 | 913 | | |
908 | 914 | | |
| |||
2058 | 2064 | | |
2059 | 2065 | | |
2060 | 2066 | | |
2061 | | - | |
2062 | | - | |
2063 | | - | |
2064 | 2067 | | |
2065 | 2068 | | |
2066 | 2069 | | |
| |||
2104 | 2107 | | |
2105 | 2108 | | |
2106 | 2109 | | |
2107 | | - | |
2108 | | - | |
2109 | | - | |
2110 | 2110 | | |
2111 | 2111 | | |
2112 | 2112 | | |
| |||
5033 | 5033 | | |
5034 | 5034 | | |
5035 | 5035 | | |
| 5036 | + | |
| 5037 | + | |
| 5038 | + | |
| 5039 | + | |
| 5040 | + | |
| 5041 | + | |
| 5042 | + | |
| 5043 | + | |
| 5044 | + | |
| 5045 | + | |
| 5046 | + | |
| 5047 | + | |
| 5048 | + | |
| 5049 | + | |
| 5050 | + | |
| 5051 | + | |
| 5052 | + | |
| 5053 | + | |
| 5054 | + | |
| 5055 | + | |
| 5056 | + | |
| 5057 | + | |
| 5058 | + | |
| 5059 | + | |
| 5060 | + | |
| 5061 | + | |
| 5062 | + | |
| 5063 | + | |
| 5064 | + | |
| 5065 | + | |
| 5066 | + | |
| 5067 | + | |
| 5068 | + | |
| 5069 | + | |
| 5070 | + | |
| 5071 | + | |
| 5072 | + | |
| 5073 | + | |
| 5074 | + | |
| 5075 | + | |
| 5076 | + | |
| 5077 | + | |
| 5078 | + | |
| 5079 | + | |
| 5080 | + | |
| 5081 | + | |
| 5082 | + | |
| 5083 | + | |
| 5084 | + | |
| 5085 | + | |
| 5086 | + | |
| 5087 | + | |
| 5088 | + | |
| 5089 | + | |
| 5090 | + | |
| 5091 | + | |
| 5092 | + | |
| 5093 | + | |
| 5094 | + | |
| 5095 | + | |
| 5096 | + | |
| 5097 | + | |
| 5098 | + | |
| 5099 | + | |
| 5100 | + | |
| 5101 | + | |
| 5102 | + | |
| 5103 | + | |
| 5104 | + | |
| 5105 | + | |
| 5106 | + | |
| 5107 | + | |
| 5108 | + | |
| 5109 | + | |
| 5110 | + | |
| 5111 | + | |
| 5112 | + | |
| 5113 | + | |
| 5114 | + | |
0 commit comments