Repository navigation
fix: don't resurrect removed content in replace/replaceAll - #352
Merged
Merged
Conversation
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #223.
replace/replaceAllsearch the original string by index and thenoverwritethe matched range. When those characters had already been removed, overwriting them brought the removed content back:Fix
A match whose original characters have been removed no longer exists in the output, so it should not be edited.
replace/replaceAllnow skip matches landing on removed content and, for the single-match variants, advance to the first match still present in the output. The non-global regexp path keeps usingString.prototype.match(so a customSymbol.matchis still honoured) and only scans forward when the first match turns out to be removed.This PR was created with the help of an agent.