Skip to content

Move @types/estree to dependencies instead of devDeps #35

@Ayc0

Description

@Ayc0

As estree is exposed in the types used by estree-walker, when using estree-walker with a strict package manager like yarn pnp, TypeScript warns us that it cannot find the package estree when using estree-walker:

image

Here is the error I have in TypeScript:

.yarn/cache/estree-walker-npm-3.0.1-f100136724-002ec6bba6.zip/node_modules/estree-walker/types/index.d.ts(18,56): error TS2307: Cannot find module 'estree' or its corresponding type declarations.

Moving @types/estree to the deps would allow other package to directly find estree (as devDeps are not installed by other packages, but deps are)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions