Repository navigation
Update CI to Xcode 26.2 - #6088
Merged
Merged
Conversation
This reverts commit 4e21c2f.
Member
Author
|
@RCGitBot please test |
tonidero
approved these changes
Jan 16, 2026
tonidero
left a comment
Contributor
There was a problem hiding this comment.
💯 Thanks for updating this!
10 of 11 tasks
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 27, 2026
Fixes flutter/flutter#194285 (hopefully) The main cause of flutter/flutter#194285 (where `Product.products(for:)` returned `[]` across StoreKit 2 tests on the iOS 27 simulator) was fixed in #13213 by preventing the example app from calling StoreKit APIs before `SKTestSession` initialized. However, `testGetProductsWithStoreKitError` and `testFailedNetworkErrorPurchase` remains fragile in iOS 26.2+ This is still because product caching in `StoreKitTest` is still 1. Opaque 2. unable to be manually cleared - the product cache sticks around even after calling `resetToDefaultState()`. Thus, the state of the cache depends on the order that the tests will run. :/ So, if a test that purchases a product succeeds, if we later hit `setSimulatedError(..., forAPI: .loadProducts)`, the cached product will be returned, causing the test to fail. This is an issue that RevenueCat also ran into as shown here: RevenueCat/purchases-ios#6088, where they skip tests using `.loadProduct` for anything above ios 26. Instead of keeping dead tests around, I think its fair to just remove them and avoid just keeping dead code around till the end of time. Additionally, the code paths tested by the removed tests are already being hit by `testFailedProductUnavilablePurchase`, so we arent really losing coverage. Additionally in this PR I fix up some leaky states between tests. ## Pre-Review Checklist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
testFetchProductsWithIdentifiersSK2ErrorTracksCorrectlyon iOS 26 due to a known Apple bugKnown Issue
The test
testFetchProductsWithIdentifiersSK2ErrorTracksCorrectlyis skipped on iOS 26 becauseSKTestSession.setSimulatedError()doesn't work for the.loadProductsAPI in iOS 26.2 (I could reproduce locally). This has been reported as an StoreKitTest framework bug:🔗 Apple Developer Forums: SKTestSession.setSimulatedError() not working for .loadProducts API in iOS 26.2