Skip to content
This repository was archived by the owner on Nov 15, 2022. It is now read-only.

Conversation

@ghost
Copy link

@ghost ghost commented Oct 5, 2019

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • WordPress version:
  • PHP version:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ghost ghost requested a review from Remzi1993 as a code owner October 5, 2019 09:50
@welcome
Copy link

welcome bot commented Oct 5, 2019

Thanks for opening this pull request! Please check out our contributing guidelines.

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit dc77a72 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Owner

@Remzi1993 Remzi1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your pull request is accepted!

@Remzi1993 Remzi1993 merged commit ff829cb into master Oct 5, 2019
@welcome
Copy link

welcome bot commented Oct 5, 2019

Congrats on merging your first pull request! We here at jQuery Manager for WordPress are proud of you!

@delete-merged-branch delete-merged-branch bot deleted the anushka713-patch-1 branch October 5, 2019 10:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant