Skip to content

Additional checks around enum parsing#549

Merged
RehanSaeed merged 2 commits intoRehanSaeed:mainfrom
Turnerj:better-handling-around-enum-parsing
May 10, 2023
Merged

Additional checks around enum parsing#549
RehanSaeed merged 2 commits intoRehanSaeed:mainfrom
Turnerj:better-handling-around-enum-parsing

Conversation

@Turnerj
Copy link
Copy Markdown
Collaborator

@Turnerj Turnerj commented Dec 23, 2022

Closes #547

This includes additional tests for EnumHelper. I did look at using InternalsVisibleTo instead of making EnumHelper public but that was going to be a pain due to the strong naming of the main projects, needing to have a public key (not just the public token) within the declaration of InternalsVisibleTo for Schema.NET.Test.

@Turnerj Turnerj added bug Issues describing a bug or pull requests fixing a bug. patch Pull requests requiring a patch version update according to semantic versioning. labels Dec 23, 2022
@github-actions github-actions bot added enhancement Issues describing an enhancement or pull requests adding an enhancement. maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. labels Dec 23, 2022
@Turnerj Turnerj requested a review from RehanSaeed December 23, 2022 07:14
@RehanSaeed
Copy link
Copy Markdown
Owner

RehanSaeed commented Mar 16, 2023 •
edited
Loading

I wasted half an hour getting InternalsVisibleTo to work both using an assembly attribute and the new csproj XML element but it just doesn't seem to want to work. Maybe has something to do with multi-targetting, not sure. Putting the public key here:

00240000048000009400000006020000002400005253413100040000010001007320f17cde01a37b8b3dff91961943f76893c63352544608de15974586e17739e0b232cdc8cc8762b40d988a21522024abca8116605ed1c8958f350bc6ca4594aa1ca61c1906d85ee76df8d9b404ffd65a5f6efeddd486bddd5b74ff9a7449af0dc9d43da753a3023b20ca616e8313e82a18719b6551f37c45c8d8e4e4cf9bac

Happy to approve. Just need to fix the build warning.

RehanSaeed
RehanSaeed previously approved these changes Mar 16, 2023
View reviewed changes
@RehanSaeed RehanSaeed removed the enhancement Issues describing an enhancement or pull requests adding an enhancement. label Mar 16, 2023
@Turnerj @RehanSaeed
Additional checks around enum parsing
f1a3acc 
This includes additional tests for EnumHelper.
@RehanSaeed RehanSaeed force-pushed the better-handling-around-enum-parsing branch from 7241acf to f1a3acc Compare May 9, 2023 16:14
@github-actions github-actions bot added the enhancement Issues describing an enhancement or pull requests adding an enhancement. label May 9, 2023
@RehanSaeed
Update EnumHelper.cs
88a3703 
Check for null
@RehanSaeed RehanSaeed removed the maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. label May 10, 2023
@github-actions github-actions bot added the maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. label May 10, 2023
@RehanSaeed RehanSaeed removed enhancement Issues describing an enhancement or pull requests adding an enhancement. maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. labels May 10, 2023
@RehanSaeed RehanSaeed merged commit 5c01227 into RehanSaeed:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RehanSaeed RehanSaeed RehanSaeed left review comments

Assignees

No one assigned

Labels

bug Issues describing a bug or pull requests fixing a bug. patch Pull requests requiring a patch version update according to semantic versioning.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Exception thrown "startIndex cannot be larger than length of string. (Parameter 'startIndex')"

2 participants

@Turnerj @RehanSaeed