Skip to content

Support JSON comments#548

Merged
RehanSaeed merged 4 commits intoRehanSaeed:mainfrom
Turnerj:support-json-comments
May 10, 2023
Merged

Support JSON comments#548
RehanSaeed merged 4 commits intoRehanSaeed:mainfrom
Turnerj:support-json-comments

Conversation

@Turnerj
Copy link
Copy Markdown
Collaborator

@Turnerj Turnerj commented Dec 23, 2022

Closes #416

@Turnerj Turnerj added enhancement Issues describing an enhancement or pull requests adding an enhancement. patch Pull requests requiring a patch version update according to semantic versioning. labels Dec 23, 2022
@Turnerj Turnerj requested a review from RehanSaeed December 23, 2022 06:17
@github-actions github-actions bot added the maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. label Dec 23, 2022
RehanSaeed
RehanSaeed previously approved these changes May 9, 2023
View reviewed changes
Copy link
Copy Markdown
Owner

@RehanSaeed RehanSaeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@RehanSaeed RehanSaeed added minor Pull requests requiring a minor version update according to semantic versioning. and removed maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. patch Pull requests requiring a patch version update according to semantic versioning. labels May 9, 2023
@github-actions github-actions bot added the maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. label May 9, 2023
@RehanSaeed RehanSaeed removed the maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. label May 10, 2023
@github-actions github-actions bot added the maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. label May 10, 2023
@RehanSaeed RehanSaeed removed the maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. label May 10, 2023
@RehanSaeed RehanSaeed merged commit a183ff7 into RehanSaeed:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RehanSaeed RehanSaeed RehanSaeed left review comments

Assignees

No one assigned

Labels

enhancement Issues describing an enhancement or pull requests adding an enhancement. minor Pull requests requiring a minor version update according to semantic versioning.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot deserialize json that contains comment

2 participants

@Turnerj @RehanSaeed