Skip to content

Further Nullable Improvements#264

Merged
RehanSaeed merged 1 commit intomainfrom
further-nullable-improvements
Mar 23, 2021
Merged

Further Nullable Improvements#264
RehanSaeed merged 1 commit intomainfrom
further-nullable-improvements

Conversation

@RehanSaeed
Copy link
Copy Markdown
Owner

@RehanSaeed RehanSaeed commented Mar 23, 2021 •
edited
Loading

  • Further nullable improvements.
  • Also realized we were not using Span<T> when targeting .NET 5, so fixed that.
  • Use is not null.

@RehanSaeed RehanSaeed added enhancement Issues describing an enhancement or pull requests adding an enhancement. patch Pull requests requiring a patch version update according to semantic versioning. labels Mar 23, 2021
@RehanSaeed RehanSaeed requested a review from Turnerj March 23, 2021 09:49
@RehanSaeed RehanSaeed mentioned this pull request Mar 23, 2021
Merged
Turnerj
Turnerj approved these changes Mar 23, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Turnerj Turnerj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RehanSaeed RehanSaeed merged commit b6ef2f8 into main Mar 23, 2021
@RehanSaeed RehanSaeed deleted the further-nullable-improvements branch March 23, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Turnerj Turnerj Turnerj approved these changes

Assignees

No one assigned

Labels

enhancement Issues describing an enhancement or pull requests adding an enhancement. patch Pull requests requiring a patch version update according to semantic versioning.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RehanSaeed @Turnerj