Skip to content

Bump Newtonsoft.Json from 12.0.3 to 13.0.1#263

Merged
RehanSaeed merged 2 commits intomainfrom
dependabot/nuget/Newtonsoft.Json-13.0.1
Mar 23, 2021
Merged

Bump Newtonsoft.Json from 12.0.3 to 13.0.1#263
RehanSaeed merged 2 commits intomainfrom
dependabot/nuget/Newtonsoft.Json-13.0.1

Conversation

@dependabot-preview
Copy link
Copy Markdown
Contributor

@dependabot-preview dependabot-preview bot commented Mar 23, 2021

Bumps Newtonsoft.Json from 12.0.3 to 13.0.1.

Release notes

Sourced from Newtonsoft.Json's releases.

13.0.1

  • New feature - Add JsonSelectSettings with configuration for a regex timeout
  • Change - Remove portable assemblies from NuGet package
  • Change - JsonReader and JsonSerializer MaxDepth defaults to 64
  • Fix - Fixed throwing missing member error on ignored fields
  • Fix - Fixed various nullable annotations
  • Fix - Fixed annotations not being copied when tokens are cloned
  • Fix - Fixed naming strategy not being used when deserializing dictionary enum keys
  • Fix - Fixed serializing nullable struct dictionaries
  • Fix - Fixed JsonWriter.WriteToken to allow null with string token
  • Fix - Fixed missing error when deserializing JToken with a contract type mismatch
  • Fix - Fixed JTokenWriter when writing comment to an object
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file. major Pull requests requiring a major version update according to semantic versioning. labels Mar 23, 2021
@RehanSaeed RehanSaeed added maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. patch Pull requests requiring a patch version update according to semantic versioning. and removed major Pull requests requiring a major version update according to semantic versioning. labels Mar 23, 2021
@RehanSaeed
Copy link
Copy Markdown
Owner

RehanSaeed commented Mar 23, 2021

This PR has errors seemingly because of nullable changes in Newtonsoft.Json which I've now fixed.

@Turnerj xUnit has support for nullable but it has not been released. This PR would not have errored if we had that support e.g. Assert.NotNull uses the [NotNull] attribute for it's parameter.

@Turnerj
Copy link
Copy Markdown
Collaborator

Turnerj commented Mar 23, 2021

Does that attribute work even if the target framework doesn't support it? I had a look at using it in our own code in a few places where we have Try* methods but wouldn't compile in anything but .NET 5 from memory. Maybe it is different when it is the dependency that has it?

@RehanSaeed
Copy link
Copy Markdown
Owner

RehanSaeed commented Mar 23, 2021

Looks like we'd have to use #if if we want to sprinkle the nullable attributes on our code :(.

Raised #264 to do just that. We'd need to drop .NET full framework and upgrade netstandard2.0 to 2.1 to switch 100% to nullable.

@RehanSaeed RehanSaeed merged commit 462e14c into main Mar 23, 2021
@RehanSaeed RehanSaeed deleted the dependabot/nuget/Newtonsoft.Json-13.0.1 branch March 23, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file. maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. patch Pull requests requiring a patch version update according to semantic versioning.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RehanSaeed @Turnerj