Merged
Conversation
Turnerj
approved these changes
Nov 18, 2020
Collaborator
|
Looks good to me! Wasn't sure that C# 9 features were going to be supported by older runtimes (eg. Framework) as I remember seeing something saying that new C# features were going to coincide with new .NET releases but it is pretty cool to find out that at least things like While this is not directly relevant to this issue, thought I would share something that I found out recently with some Microsoft.* 5.0.0 dependencies: Azure/azure-functions-vs-build-sdk#472 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
netstandard1.1..editorconfigfile which has changed in a breaking way (Add Support for VS 16.8 Which Introduced Breaking Changes EditorConfig#42) to support VS 16.8.EnforceCodeStyleInBuild(This is awesome).is objecttois not null. This has been on my mind for a long time. There is a lot more that could be done but getting some C# 9 in early.