Skip to content

Upgrade to .NET Core SDK 5.0.100#226

Merged
RehanSaeed merged 1 commit intomainfrom
dotnet-5
Nov 18, 2020
Merged

Upgrade to .NET Core SDK 5.0.100#226
RehanSaeed merged 1 commit intomainfrom
dotnet-5

Conversation

@RehanSaeed
Copy link
Copy Markdown
Owner

  • Upgrade to .NET Core SDK 5.0.100.
  • Dropped support for netstandard1.1.
  • Update the .editorconfig file which has changed in a breaking way (Add Support for VS 16.8 Which Introduced Breaking Changes EditorConfig#42) to support VS 16.8.
  • Enable EnforceCodeStyleInBuild (This is awesome).
  • Fix all the new warnings.
  • Switch from is object to is not null. This has been on my mind for a long time. There is a lot more that could be done but getting some C# 9 in early.

@RehanSaeed RehanSaeed added maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. patch Pull requests requiring a patch version update according to semantic versioning. labels Nov 17, 2020
@RehanSaeed RehanSaeed requested a review from Turnerj November 17, 2020 14:18
@RehanSaeed RehanSaeed changed the base branch from main to master November 17, 2020 14:33
@RehanSaeed RehanSaeed changed the base branch from master to main November 17, 2020 14:33
@Turnerj
Copy link
Copy Markdown
Collaborator

Turnerj commented Nov 18, 2020

Looks good to me! Wasn't sure that C# 9 features were going to be supported by older runtimes (eg. Framework) as I remember seeing something saying that new C# features were going to coincide with new .NET releases but it is pretty cool to find out that at least things like is not null will be.

While this is not directly relevant to this issue, thought I would share something that I found out recently with some Microsoft.* 5.0.0 dependencies: Azure/azure-functions-vs-build-sdk#472
This has nothing to do with us targeting .NET 5 in our tool/tests or using the SDK but if we were to update the wrong assemblies, it may cause issues under particular circumstances.

@RehanSaeed RehanSaeed merged commit 80b3e88 into main Nov 18, 2020
@RehanSaeed RehanSaeed deleted the dotnet-5 branch November 18, 2020 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. patch Pull requests requiring a patch version update according to semantic versioning.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants