Skip to content

Update Schema & Use HTTPS URL's#202

Merged
RehanSaeed merged 4 commits intomasterfrom
update-schema
Nov 2, 2020
Merged

Update Schema & Use HTTPS URL's#202
RehanSaeed merged 4 commits intomasterfrom
update-schema

Conversation

@RehanSaeed
Copy link
Copy Markdown
Owner

@RehanSaeed RehanSaeed commented Sep 3, 2020 •
edited
Loading

  • Updated the schema from schema.org.
  • Fixed URL for jsonld from schema.org changed? #197.
  • Schema.org provide a choice of new URL's. I've picked the one that prefixes all schema's with https instead of http and also updated all tests to match. This is a breaking change.
  • Fixed a bug where a type with a single parent that was a pending type would be omitted even though it might have other parent types that were not pending.
  • Pushing NuGet package to GitHub Actions now works.
  • Updated the .NET Core SDK to 3.1.403.
  • Updated .editorconfig file.

@RehanSaeed RehanSaeed added enhancement Issues describing an enhancement or pull requests adding an enhancement. major Pull requests requiring a major version update according to semantic versioning. labels Sep 3, 2020
@RehanSaeed RehanSaeed requested a review from Turnerj September 3, 2020 10:37
@RehanSaeed RehanSaeed mentioned this pull request Sep 3, 2020
Closed
Turnerj
Turnerj approved these changes Sep 3, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Turnerj Turnerj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@RehanSaeed RehanSaeed changed the title Update Schema & use https URL's Update Schema & Use HTTPS URL's Nov 2, 2020
@RehanSaeed RehanSaeed merged commit 787ae1d into master Nov 2, 2020
@RehanSaeed RehanSaeed deleted the update-schema branch November 2, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Turnerj Turnerj Turnerj approved these changes

Assignees

No one assigned

Labels

enhancement Issues describing an enhancement or pull requests adding an enhancement. major Pull requests requiring a major version update according to semantic versioning.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

URL for jsonld from schema.org changed?

2 participants

@RehanSaeed @Turnerj