Merged
Conversation
Collaborator
|
If I understand this right, it sounds really awesome! Basically every PR merged "builds" a draft release on GitHub and when you're ready, you just publish that release yeah? |
Owner
Author
|
That's the idea. This is the first time I've tried it. |
Collaborator
|
Cool - I'll go over it more thoroughly tomorrow but at a glance, it looks good to me. 🙂 |
Turnerj
approved these changes
Jun 4, 2020
Collaborator
Turnerj
left a comment
There was a problem hiding this comment.
Yep, all looks good to me. If this works well, I'll likely do this in my other libraries too.
Collaborator
|
Just FYI, we don't have the Major, Minor or Patch labels setup yet. |
Owner
Author
|
Same. This is the test bed repo. Added the labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically drafts releases. Living the dream!
https://github.com/marketplace/actions/release-drafter
enhancementordependencieslabels are marked as new features.buglabels are marked as bug fixes.maintenancelabels are marked as maintenance.major,minororpatchlabels determine the version number generated in the release. The default is patch if no label is specified. Since we use MinVer, it takes the release version and then automagically uses that to version and deploy the NuGet package.In theory, all I need to do now, is hit the big green publish button.