Skip to content

Add Multiple nested Directory.Build.props#146

Merged
RehanSaeed merged 4 commits intomasterfrom
nested-directory-build-props
Mar 21, 2020
Merged

Add Multiple nested Directory.Build.props#146
RehanSaeed merged 4 commits intomasterfrom
nested-directory-build-props

Conversation

@RehanSaeed
Copy link
Copy Markdown
Owner

No description provided.

@RehanSaeed RehanSaeed requested a review from Turnerj March 20, 2020 12:31
@RehanSaeed
Copy link
Copy Markdown
Owner Author

Not sure how I feel about this one. The tests is less useful I think. You could conceivably want to use a different test framework for example.

@Turnerj
Copy link
Copy Markdown
Collaborator

Turnerj commented Mar 21, 2020

I haven't had a case myself where I've wanted to mix and match test frameworks across multiple test projects in a single solution.

It does kinda suck that Directory.Build.props doesn't automatically import/merge from parent directories - I really thought that's how it worked.

Your changes look good to me!

@RehanSaeed RehanSaeed merged commit e7b778c into master Mar 21, 2020
@RehanSaeed RehanSaeed deleted the nested-directory-build-props branch March 21, 2020 19:33
@RehanSaeed RehanSaeed added the maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. label Jun 4, 2020
@RehanSaeed RehanSaeed changed the title Add Multiple nested Directory.Build.props Add Multiple nested Directory.Build.props Jun 4, 2020
@RehanSaeed RehanSaeed changed the title Add Multiple nested Directory.Build.props Add Multiple nested Directory.Build.props Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Pull requests that perform maintenance on the project but add no features or bug fixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants