Improve performance by skip additional loops

Turnerj · Turnerj · commit 09069a39be89 · 2021-02-28T16:39:37.000+10:30
Previous each schema class would need to look at every other schema class. Now that processing is done once and then checked again via a HashSet. Similarly with properties, each property was iterated for every class - now that happens once with each class only looping over its properties.
diff --git a/Tools/Schema.NET.Tool/Services/SchemaService.cs b/Tools/Schema.NET.Tool/Services/SchemaService.cs
@@ -40,6 +40,14 @@ public async Task<IEnumerable<GeneratorSchemaObject>> GetObjectsAsync()
                 schemaClasses.Where(c => c.IsEnum).Select(c => c.Label),
                 StringComparer.Ordinal);
 
+            var knownSchemaClasses = new HashSet<Uri>(
+                schemaClasses.Select(c => c.Id));
+
+            var classPropertyMap = schemaProperties
+                .SelectMany(p => p.DomainIncludes.Select(i => (Id: i, Property: p)))
+                .GroupBy(x => x.Id)
+                .ToDictionary(g => g.Key, g => g.Select(p => p.Property).ToArray());
+
             var enumerations = new List<GeneratorSchemaEnumeration>();
             var classes = new List<GeneratorSchemaClass>();
             foreach (var schemaClass in schemaClasses
@@ -52,7 +60,12 @@ public async Task<IEnumerable<GeneratorSchemaObject>> GetObjectsAsync()
                 }
                 else
                 {
-                    var @class = TranslateClass(schemaClass, schemaClasses, schemaProperties, isEnumMap);
+                    if (!classPropertyMap.TryGetValue(schemaClass.Id, out var classProperties))
+                    {
+                        classProperties = Array.Empty<Models.SchemaProperty>();
+                    }
+
+                    var @class = TranslateClass(schemaClass, schemaClasses, classProperties, isEnumMap, knownSchemaClasses);
                     classes.Add(@class);
                 }
             }
@@ -222,7 +235,8 @@ private static GeneratorSchemaClass TranslateClass(
             Models.SchemaClass schemaClass,
             IEnumerable<Models.SchemaClass> schemaClasses,
             IEnumerable<Models.SchemaProperty> schemaProperties,
-            HashSet<string> isEnumMap)
+            HashSet<string> isEnumMap,
+            HashSet<Uri> knownSchemaClasses)
         {
             var @class = new GeneratorSchemaClass()
             {
@@ -232,13 +246,11 @@ private static GeneratorSchemaClass TranslateClass(
                 Name = StartsWithNumber.IsMatch(schemaClass.Label) ? $"_{schemaClass.Label}" : schemaClass.Label,
             };
 
-            @class.Parents.AddRange(schemaClasses
-                .Where(x => schemaClass.SubClassOfIds.Contains(x.Id))
-                .Where(x => !x.IsPending)
-                .Select(x => new GeneratorSchemaClass() { Id = x.Id }));
+            @class.Parents.AddRange(schemaClass.SubClassOfIds
+                .Where(id => knownSchemaClasses.Contains(id))
+                .Select(id => new GeneratorSchemaClass() { Id = id }));
 
             var properties = schemaProperties
-                .Where(x => x.DomainIncludes.Contains(schemaClass.Id))
                 .Select(x =>
                 {
                     var propertyName = GetPropertyName(x.Label);
